From: Vinod Koul <vkoul@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org,
jank@cadence.com, srinivas.kandagatla@linaro.org,
slawomir.blauciak@intel.com,
Bard liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>
Subject: Re: [alsa-devel] [PATCH v2 5/5] soundwire: intel: free all resources on hw_free()
Date: Thu, 13 Feb 2020 09:53:44 +0530 [thread overview]
Message-ID: <20200213042344.GC2618@vkoul-mobl> (raw)
In-Reply-To: <c8219635-30be-9695-a3f5-cd649aa6fab7@linux.intel.com>
On 12-02-20, 09:37, Pierre-Louis Bossart wrote:
> Hi Vinod,
>
> > > +static int intel_free_stream(struct sdw_intel *sdw,
> > > + struct snd_pcm_substream *substream,
> > > + struct snd_soc_dai *dai,
> > > + int link_id)
> > > +{
> > > + struct sdw_intel_link_res *res = sdw->link_res;
> > > + struct sdw_intel_stream_free_data free_data;
> >
> > where is this struct sdw_intel_stream_free_data defined. I dont see it
> > in this patch or this series..
>
> the definition is already upstream :-)
Oops did i look at wrong branch, sorry!
> > > + ret = intel_free_stream(sdw, substream, dai, sdw->instance);
> > > + if (ret < 0) {
> > > + dev_err(dai->dev, "intel_free_stream: failed %d", ret);
> > > + return ret;
> > > + }
> > > +
> > > + sdw_release_stream(dma->stream);
> >
> > I think, free the 'name' here would be apt
>
> Right, this is something we discussed with Rander shortly before Chinese New
> Year and we wanted to handle this with a follow-up patch, would that work
> for you? if not I can send a v3, your choice.
It would be better if we fix this up in this series :)
--
~Vinod
next prev parent reply other threads:[~2020-02-13 4:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 23:42 [PATCH v2 0/5] soundwire: intel: add DAI callbacks Pierre-Louis Bossart
2020-01-14 23:42 ` [PATCH v2 1/5] soundwire: intel: rename res field as link_res Pierre-Louis Bossart
2020-01-14 23:42 ` [PATCH v2 2/5] soundwire: intel: add prepare support in sdw dai driver Pierre-Louis Bossart
2020-01-14 23:42 ` [PATCH v2 3/5] soundwire: intel: add trigger " Pierre-Louis Bossart
2020-01-14 23:42 ` [PATCH v2 4/5] soundwire: intel: add sdw_stream_setup helper for .startup callback Pierre-Louis Bossart
2020-02-12 10:12 ` Vinod Koul
2020-01-14 23:42 ` [PATCH v2 5/5] soundwire: intel: free all resources on hw_free() Pierre-Louis Bossart
2020-02-12 10:15 ` Vinod Koul
2020-02-12 15:37 ` [alsa-devel] " Pierre-Louis Bossart
2020-02-13 4:23 ` Vinod Koul [this message]
2020-02-13 15:05 ` Pierre-Louis Bossart
2020-02-10 14:28 ` [PATCH v2 0/5] soundwire: intel: add DAI callbacks Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213042344.GC2618@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=slawomir.blauciak@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).