linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/1] checkpatch: support "base-commit:" format
@ 2020-02-13  5:50 John Hubbard
  2020-02-13  5:50 ` [PATCH v2 1/1] " John Hubbard
  0 siblings, 1 reply; 3+ messages in thread
From: John Hubbard @ 2020-02-13  5:50 UTC (permalink / raw)
  To: Joe Perches
  Cc: Andy Whitcroft, Jonathan Corbet, Konstantin Ryabitsev, LKML,
	John Hubbard

========================================================================
Changes since v1:

* Changed to extend an existing regex line, instead of adding a new line
  (suggested by Joe Perches). Adjusted the commit description slightly
  to match.

========================================================================

In order to support the get-lore-mbox.py tool described in [1], I ran:

    git format-patch --base=<commit> --cover-letter <revrange>

...which generated a "base-commit: <commit-hash>" tag at the end of the
cover letter, just like you can see at the end of this cover letter.
However, checkpatch.pl generated an error upon encounting
"base-commit:" in the cover letter.

So, I suspect that no one is actually using the --base option yet, but
if [1] leads to get-lore-mbox.py and similar scripts becoming popular,
then we'll want checkpatch.pl to work well with them. This tiny patch
does that.

An alternative approach to fixing this would be to make the --base
option emit a checkpatch-friendly commit style. However, I think that's
much less desirable, because base-commit is really just for tools
(mainly "git am") to consume. And so we don't really want it to take up
any more valuable lines in the commit letter than it already does.

thanks,
John Hubbard
NVIDIA

John Hubbard (1):
  checkpatch: support "base-commit:" format

 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 0bf999f9c5e74c7ecf9dafb527146601e5c848b9
-- 
2.25.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 1/1] checkpatch: support "base-commit:" format
  2020-02-13  5:50 [PATCH v2 0/1] checkpatch: support "base-commit:" format John Hubbard
@ 2020-02-13  5:50 ` John Hubbard
  2020-02-13 15:25   ` Joe Perches
  0 siblings, 1 reply; 3+ messages in thread
From: John Hubbard @ 2020-02-13  5:50 UTC (permalink / raw)
  To: Joe Perches
  Cc: Andy Whitcroft, Jonathan Corbet, Konstantin Ryabitsev, LKML,
	John Hubbard

In order to support the get-lore-mbox.py tool described in [1], I ran:

    git format-patch --base=<commit> --cover-letter <revrange>

...which generated a "base-commit: <commit-hash>" tag at the end of the
cover letter. However, checkpatch.pl generated an error upon encounting
"base-commit:" in the cover letter:

    "ERROR: Please use git commit description style..."

...because it found the "commit" keyword, and failed to recognize that
it was part of the "base-commit" phrase, and as such, should not be
subjected to the same commit description style rules.

Update checkpatch.pl to include a special case for "base-commit:" (at
the start of the line, possibly with some leading whitespace) so
that that tag no longer generates a checkpatch error.

[1] https://lwn.net/Articles/811528/ "Better tools for kernel
    developers"

Cc: Andy Whitcroft <apw@canonical.com>
Suggested-by: Joe Perches <joe@perches.com>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a63380c6b0d2..1e66fc7a2f2f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2761,7 +2761,7 @@ sub process {
 
 # Check for git id commit length and improperly formed commit descriptions
 		if ($in_commit_log && !$commit_log_possible_stack_dump &&
-		    $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink):/i &&
+		    $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink|base-commit):/i &&
 		    $line !~ /^This reverts commit [0-9a-f]{7,40}/ &&
 		    ($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
 		     ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i &&
-- 
2.25.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/1] checkpatch: support "base-commit:" format
  2020-02-13  5:50 ` [PATCH v2 1/1] " John Hubbard
@ 2020-02-13 15:25   ` Joe Perches
  0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2020-02-13 15:25 UTC (permalink / raw)
  To: John Hubbard, Andrew Morton
  Cc: Andy Whitcroft, Jonathan Corbet, Konstantin Ryabitsev, LKML

On Wed, 2020-02-12 at 21:50 -0800, John Hubbard wrote:
> In order to support the get-lore-mbox.py tool described in [1], I ran:
> 
>     git format-patch --base=<commit> --cover-letter <revrange>
> 
> ...which generated a "base-commit: <commit-hash>" tag at the end of the
> cover letter. However, checkpatch.pl generated an error upon encounting
> "base-commit:" in the cover letter:
> 
>     "ERROR: Please use git commit description style..."
> 
> ...because it found the "commit" keyword, and failed to recognize that
> it was part of the "base-commit" phrase, and as such, should not be
> subjected to the same commit description style rules.
> 
> Update checkpatch.pl to include a special case for "base-commit:" (at
> the start of the line, possibly with some leading whitespace) so
> that that tag no longer generates a checkpatch error.
> 
> [1] https://lwn.net/Articles/811528/ "Better tools for kernel
>     developers"
> 
> Cc: Andy Whitcroft <apw@canonical.com>
> Suggested-by: Joe Perches <joe@perches.com>

Acked-by: Joe Perches <joe@perches.com>

Andrew, can you pick this up please?

> Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a63380c6b0d2..1e66fc7a2f2f 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2761,7 +2761,7 @@ sub process {
>  
>  # Check for git id commit length and improperly formed commit descriptions
>  		if ($in_commit_log && !$commit_log_possible_stack_dump &&
> -		    $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink):/i &&
> +		    $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink|base-commit):/i &&
>  		    $line !~ /^This reverts commit [0-9a-f]{7,40}/ &&
>  		    ($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
>  		     ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i &&


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-13 15:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-13  5:50 [PATCH v2 0/1] checkpatch: support "base-commit:" format John Hubbard
2020-02-13  5:50 ` [PATCH v2 1/1] " John Hubbard
2020-02-13 15:25   ` Joe Perches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).