From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D75F6C3F68F for ; Thu, 13 Feb 2020 12:52:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B9E6B218AC for ; Thu, 13 Feb 2020 12:52:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729931AbgBMMwe (ORCPT ); Thu, 13 Feb 2020 07:52:34 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:43272 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729557AbgBMMwe (ORCPT ); Thu, 13 Feb 2020 07:52:34 -0500 Received: from [95.91.247.236] (helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1j2Dyq-0008Ec-H6; Thu, 13 Feb 2020 12:52:32 +0000 Date: Thu, 13 Feb 2020 13:52:31 +0100 From: Christian Brauner To: Tejun Heo Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Oleg Nesterov , Peter Zijlstra Subject: Re: [PATCH v6 0/6] clone3 & cgroups: allow spawning processes into cgroups Message-ID: <20200213125231.3vod5lckaej6na7w@wittgenstein> References: <20200205132623.670015-1-christian.brauner@ubuntu.com> <20200212230127.GA88887@mtj.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200212230127.GA88887@mtj.thefacebook.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 12, 2020 at 06:01:27PM -0500, Tejun Heo wrote: > On Wed, Feb 05, 2020 at 02:26:17PM +0100, Christian Brauner wrote: > > Hey Tejun, > > > > This is v6 of the promised series to enable spawning processes into a > > target cgroup different from the parent's cgroup. > > Applied 1-6 to cgroup/for-5.7. There was a conflict with 0cd9d33ace33 > ("cgroup: init_tasks shouldn't be linked to the root cgroup") which > got fixed up while applying. I'd really appreciate if you can take a > look to see everything is ok. Looked at it just now and all seems sane. The reference to init_tasks threw me off at first. I initially thought you're talking about pid namespace inits but you mean tasks created via fork_idle() here. Since those tasks can't be created with CLONE_INTO_CGROUP set it's perfectly safe to set cset = NULL unconditionally. Thanks for fixing the merge conflict! > > Thanks a lot for working on this. This is really great. Thanks, I think so too! Christian