* [PATCH] fs: nfsd: nfs4state.c: Use built-in RCU list checking
@ 2020-02-13 15:03 madhuparnabhowmik10
2020-03-03 16:54 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: madhuparnabhowmik10 @ 2020-02-13 15:03 UTC (permalink / raw)
To: bfields, chuck.lever
Cc: linux-nfs, linux-kernel, joel, frextrite, linux-kernel-mentees,
paulmck, Madhuparna Bhowmik
From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
list_for_each_entry_rcu() has built-in RCU and lock checking.
Pass cond argument to list_for_each_entry_rcu() to silence
false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
by default.
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
---
fs/nfsd/nfs4state.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 369e574c5092..3a80721fe53d 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -4295,7 +4295,8 @@ find_file_locked(struct knfsd_fh *fh, unsigned int hashval)
{
struct nfs4_file *fp;
- hlist_for_each_entry_rcu(fp, &file_hashtbl[hashval], fi_hash) {
+ hlist_for_each_entry_rcu(fp, &file_hashtbl[hashval], fi_hash,
+ lockdep_is_held(&state_lock)) {
if (fh_match(&fp->fi_fhandle, fh)) {
if (refcount_inc_not_zero(&fp->fi_ref))
return fp;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs: nfsd: nfs4state.c: Use built-in RCU list checking
2020-02-13 15:03 [PATCH] fs: nfsd: nfs4state.c: Use built-in RCU list checking madhuparnabhowmik10
@ 2020-03-03 16:54 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2020-03-03 16:54 UTC (permalink / raw)
To: madhuparnabhowmik10
Cc: chuck.lever, linux-nfs, linux-kernel, joel, frextrite,
linux-kernel-mentees, paulmck
Applying for 5.7, thanks.--b.
On Thu, Feb 13, 2020 at 08:33:31PM +0530, madhuparnabhowmik10@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
> list_for_each_entry_rcu() has built-in RCU and lock checking.
>
> Pass cond argument to list_for_each_entry_rcu() to silence
> false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
> by default.
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> ---
> fs/nfsd/nfs4state.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 369e574c5092..3a80721fe53d 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -4295,7 +4295,8 @@ find_file_locked(struct knfsd_fh *fh, unsigned int hashval)
> {
> struct nfs4_file *fp;
>
> - hlist_for_each_entry_rcu(fp, &file_hashtbl[hashval], fi_hash) {
> + hlist_for_each_entry_rcu(fp, &file_hashtbl[hashval], fi_hash,
> + lockdep_is_held(&state_lock)) {
> if (fh_match(&fp->fi_fhandle, fh)) {
> if (refcount_inc_not_zero(&fp->fi_ref))
> return fp;
> --
> 2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-03 16:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-13 15:03 [PATCH] fs: nfsd: nfs4state.c: Use built-in RCU list checking madhuparnabhowmik10
2020-03-03 16:54 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).