From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1239AC3B18B for ; Thu, 13 Feb 2020 15:22:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D3DC42469A for ; Thu, 13 Feb 2020 15:22:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607338; bh=5hDFTEFqhTMBINghl6SqPXEuOch/SmuKxFXn9GwbzaA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ABtk46NSL/sO1KNEojome8CdHoUCD9dlCMyFgWhIQdXSsswXx+SJu4+AqckzCN7Lz yKFvaXMMpxDGi9Oq2JgNaCLNBCpf5ZzT0d4i9SHpJnPVd7dtRe1KETttVcpRUgs4bw IeaXtCcDxGHZeia+WmgL9rxt9/5wL/ZDrwYeFCx8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727781AbgBMPWS (ORCPT ); Thu, 13 Feb 2020 10:22:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:59110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727669AbgBMPWR (ORCPT ); Thu, 13 Feb 2020 10:22:17 -0500 Received: from localhost (unknown [104.132.1.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 656EB24690; Thu, 13 Feb 2020 15:22:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607336; bh=5hDFTEFqhTMBINghl6SqPXEuOch/SmuKxFXn9GwbzaA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G4XmyJ5/+5lRKWgtXXgLgSa7q3neQXDUNgZelbsZZ05BWXPyHpZW6A8c7/+2QKkPH ltf0h9McywRasfVwuKp+Oyfhm0SNB7pUWghrGwZY+XrOobcvH/NBjwUTp4F3QZttAt z71cDURU/odZbkkymxcs7MW14TJc4YOuR7AuEW0I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Oliver Neukum , Johan Hovold , Sean Young , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.4 01/91] media: iguanair: fix endpoint sanity check Date: Thu, 13 Feb 2020 07:19:18 -0800 Message-Id: <20200213151821.848596291@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200213151821.384445454@linuxfoundation.org> References: <20200213151821.384445454@linuxfoundation.org> User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold [ Upstream commit 1b257870a78b0a9ce98fdfb052c58542022ffb5b ] Make sure to use the current alternate setting, which need not be the first one by index, when verifying the endpoint descriptors and initialising the URBs. Failing to do so could cause the driver to misbehave or trigger a WARN() in usb_submit_urb() that kernels with panic_on_warn set would choke on. Fixes: 26ff63137c45 ("[media] Add support for the IguanaWorks USB IR Transceiver") Fixes: ab1cbdf159be ("media: iguanair: add sanity checks") Cc: stable # 3.6 Cc: Oliver Neukum Signed-off-by: Johan Hovold Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/rc/iguanair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c index cda4ce612dcf5..782391507e3a5 100644 --- a/drivers/media/rc/iguanair.c +++ b/drivers/media/rc/iguanair.c @@ -430,7 +430,7 @@ static int iguanair_probe(struct usb_interface *intf, int ret, pipein, pipeout; struct usb_host_interface *idesc; - idesc = intf->altsetting; + idesc = intf->cur_altsetting; if (idesc->desc.bNumEndpoints < 2) return -ENODEV; -- 2.20.1