From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7405C3B18C for ; Thu, 13 Feb 2020 15:49:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8512B20661 for ; Thu, 13 Feb 2020 15:49:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581608981; bh=FYWV3E0itvXOBUSA3WBPSQUl2JEx0E9gY563Ml6bPOY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OWSJGWx9vV6uxDwN1eKm1a/yEyeuYqsvhQqxT1rvGtjETTZwTdr3uLt7qzoYA82W2 inJQWKILlRtdWKeERFahfd+W9O6b4kxqgD9kCbIdvJJ42sjKxq+HQ3WorN3pc+QlBW Whz2kpJbTxYC8JR2c59Y9ZOroJIkmtccKnG1+IGk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387619AbgBMP0j (ORCPT ); Thu, 13 Feb 2020 10:26:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:39532 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728861AbgBMPY4 (ORCPT ); Thu, 13 Feb 2020 10:24:56 -0500 Received: from localhost (unknown [104.132.1.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EBEED246B3; Thu, 13 Feb 2020 15:24:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607496; bh=FYWV3E0itvXOBUSA3WBPSQUl2JEx0E9gY563Ml6bPOY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bzq3jSX1DuaBQUUTNt5apoUCeDiwAVVLJhVDeB4PjQ07hphZEDuiCZMoiROC0vsqr xUATLNtBsAPW3KvbP5ESRj6LXcowJUlpVv4JpAiuy3YOzlv2WEGoy2k43vYX9O9B3C YMGcTp4h55nKx6QYaiZ8UoQYfuebIplriMFxXBrI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sven Van Asbroeck , Sebastian Reichel Subject: [PATCH 4.14 048/173] power: supply: ltc2941-battery-gauge: fix use-after-free Date: Thu, 13 Feb 2020 07:19:11 -0800 Message-Id: <20200213151946.117730255@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200213151931.677980430@linuxfoundation.org> References: <20200213151931.677980430@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sven Van Asbroeck commit a60ec78d306c6548d4adbc7918b587a723c555cc upstream. This driver's remove path calls cancel_delayed_work(). However, that function does not wait until the work function finishes. This could mean that the work function is still running after the driver's remove function has finished, which would result in a use-after-free. Fix by calling cancel_delayed_work_sync(), which ensures that that the work is properly cancelled, no longer running, and unable to re-schedule itself. This issue was detected with the help of Coccinelle. Cc: stable Signed-off-by: Sven Van Asbroeck Signed-off-by: Sebastian Reichel Signed-off-by: Greg Kroah-Hartman --- drivers/power/supply/ltc2941-battery-gauge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/power/supply/ltc2941-battery-gauge.c +++ b/drivers/power/supply/ltc2941-battery-gauge.c @@ -406,7 +406,7 @@ static int ltc294x_i2c_remove(struct i2c { struct ltc294x_info *info = i2c_get_clientdata(client); - cancel_delayed_work(&info->work); + cancel_delayed_work_sync(&info->work); power_supply_unregister(info->supply); return 0; }