From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05CC9C352A3 for ; Thu, 13 Feb 2020 21:06:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D4B0520848 for ; Thu, 13 Feb 2020 21:06:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728239AbgBMVGu (ORCPT ); Thu, 13 Feb 2020 16:06:50 -0500 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]:18072 "EHLO alexa-out-sd-02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726282AbgBMVGt (ORCPT ); Thu, 13 Feb 2020 16:06:49 -0500 Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-02.qualcomm.com with ESMTP; 13 Feb 2020 13:06:49 -0800 Received: from gurus-linux.qualcomm.com ([10.46.162.81]) by ironmsg02-sd.qualcomm.com with ESMTP; 13 Feb 2020 13:06:49 -0800 Received: by gurus-linux.qualcomm.com (Postfix, from userid 383780) id 1CEA34AB6; Thu, 13 Feb 2020 13:06:49 -0800 (PST) Date: Thu, 13 Feb 2020 13:06:49 -0800 From: Guru Das Srinagesh To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: linux-pwm@vger.kernel.org, Thierry Reding , Subbaraman Narayanamurthy , linux-kernel@vger.kernel.org Subject: Re: [RESEND v5 2/2] pwm: core: Convert period and duty cycle to u64 Message-ID: <20200213210648.GA12663@codeaurora.org> References: <20200213101802.owpluhixtpor3qi3@pengutronix.de> <20200213193926.GA20183@codeaurora.org> <20200213202804.pqgbqtphuboqo6af@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200213202804.pqgbqtphuboqo6af@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Uwe, On Thu, Feb 13, 2020 at 09:28:04PM +0100, Uwe Kleine-König wrote: > Hello, > > On Thu, Feb 13, 2020 at 11:39:26AM -0800, Guru Das Srinagesh wrote: > > On Thu, Feb 13, 2020 at 11:18:02AM +0100, Uwe Kleine-König wrote: > > > Hello, > > > > > > On Wed, Feb 12, 2020 at 10:54:08AM -0800, Guru Das Srinagesh wrote: > > > > @@ -305,8 +305,8 @@ struct pwm_chip { > > > > * @duty_cycle: duty cycle of the PWM signal (in nanoseconds) > > > > */ > > > > struct pwm_capture { > > > > - unsigned int period; > > > > - unsigned int duty_cycle; > > > > + u64 period; > > > > + u64 duty_cycle; > > > > }; > > > > > > Is this last hunk a separate change? > > > > > > Otherwise looks fine. > > > > No, this is very much a part of the change and not a separate one. > > Not sure we understand each other. I wondered if conversion of the > pwm_capture stuff should be done separately. (OTOH I wonder if this is > used at all and already considered deleting it.) I see. Could you please elaborate on your concerns? I think this hunk's being in this patch makes sense as duty and period should be converted to u64 throughout the file in one go. Also, it looks like pwm_capture is being used by pwm-sti.c and pwm-stm32.c currently. Thank you. Guru Das.