LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: stable@vger.kernel.org
Cc: X86 ML <x86@kernel.org>, Yazen Ghannam <Yazen.Ghannam@amd.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/mce/amd: Fix kobject lifetime
Date: Fri, 14 Feb 2020 09:32:30 +0100
Message-ID: <20200214083230.GA13395@zn.tnic> (raw)
In-Reply-To: <20200214082801.13836-1-bp@alien8.de>

On Fri, Feb 14, 2020 at 09:28:01AM +0100, Borislav Petkov wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> Accessing the MCA thresholding controls in sysfs concurrently with CPU
> hotplug can lead to a couple of KASAN-reported issues:
> 
>   BUG: KASAN: use-after-free in sysfs_file_ops+0x155/0x180
>   Read of size 8 at addr ffff888367578940 by task grep/4019
> 
> and
> 
>   BUG: KASAN: use-after-free in show_error_count+0x15c/0x180
>   Read of size 2 at addr ffff888368a05514 by task grep/4454
> 
> for example. Both result from the fact that the threshold block
> creation/teardown code frees the descriptor memory itself instead of
> defining proper ->release function and leaving it to the driver core to
> take care of that, after all sysfs accesses have completed.
> 
> Do that and get rid of the custom freeing code, fixing the above UAFs in
> the process.
> 
>   [ bp: write commit message. ]
> 
> Fixes: 95268664390b ("[PATCH] x86_64: mce_amd support for family 0x10 processors")
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: <stable@vger.kernel.org>

Damn git-send-email: it read out Cc: stable and added it to the Cc list.
I've added

suppresscc = bodycc

to my .gitconfig.

Sorry stable guys.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  8:28 Borislav Petkov
2020-02-14  8:32 ` Borislav Petkov [this message]
2020-02-14 15:17   ` Greg KH
2020-02-14 20:11     ` Borislav Petkov
2020-02-14 20:26       ` Thomas Gleixner
2020-02-14 20:36         ` Borislav Petkov
2020-02-14 20:41         ` Greg KH
2020-02-15 13:34 ` [tip: ras/urgent] " tip-bot2 for Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200214083230.GA13395@zn.tnic \
    --to=bp@alien8.de \
    --cc=Yazen.Ghannam@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git