From: Borislav Petkov <bp@alien8.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] x86/mce: Change default mce logger to check mce->handled
Date: Fri, 14 Feb 2020 10:05:38 +0100 [thread overview]
Message-ID: <20200214090537.GF13395@zn.tnic> (raw)
In-Reply-To: <20200213222750.GC21107@agluck-desk2.amr.corp.intel.com>
On Thu, Feb 13, 2020 at 02:27:50PM -0800, Luck, Tony wrote:
> That's pretty hard with a chain. I think folks will have a conniptions
LOL. And they do already for other things so let's spare them :-)
> if we invent an error return from a notifier chain function that means
> "Go back and start over". Though if we did it would make the "handled"
> field useful for functions that didn't want to redo ... they'd just
> check if "their" bit in handled was already set.
>
> Still, seems like a terrible idea.
Yap.
> If some driver really wants multiple bites at an error on the
> chain it could register more than one handler with different
> priorities. In which case we should have "enum" names for the
> highest and lowest priorities so such a driver can go "first"
> or "last" (though such a thing would be dependent on whether
> some other driver was attempting to add a "first" or "last"
> entry on the chain).
Yap, makes sense. I'm fine with us even having a possible way to do
this, *if* someone decides she wants it.
Ok, thanks!
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-02-14 9:05 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 20:46 [RFC PATCH 0/5] New way to track mce notifier chain actions Tony Luck
2020-02-12 20:46 ` [PATCH 1/5] x86/mce: Rename "first" function as "early" Tony Luck
2020-02-12 20:46 ` [PATCH 2/5] x86/mce: Convert corrected error collector to use mce notifier Tony Luck
2020-02-12 20:46 ` [PATCH 3/5] x86/mce: Add new "handled" field to "struct mce" Tony Luck
2020-02-13 16:56 ` Borislav Petkov
2020-02-13 22:09 ` Luck, Tony
2020-02-14 8:50 ` Borislav Petkov
2020-02-12 20:46 ` [PATCH 4/5] x86/mce: Fix all mce notifiers to update the mce->handled bitmask Tony Luck
2020-02-13 17:03 ` Borislav Petkov
2020-02-13 22:19 ` Luck, Tony
2020-02-13 22:27 ` Andy Lutomirski
2020-02-13 23:08 ` Luck, Tony
2020-02-14 9:02 ` Borislav Petkov
2020-02-14 0:18 ` Thomas Gleixner
2020-02-14 8:59 ` Borislav Petkov
2020-02-12 20:46 ` [PATCH 5/5] x86/mce: Change default mce logger to check mce->handled Tony Luck
2020-02-13 17:08 ` Borislav Petkov
2020-02-13 22:27 ` Luck, Tony
2020-02-14 9:05 ` Borislav Petkov [this message]
2020-02-12 23:08 ` [RFC PATCH 0/5] New way to track mce notifier chain actions Luck, Tony
2020-02-13 5:52 ` Andy Lutomirski
2020-02-13 6:09 ` Borislav Petkov
2020-02-13 16:05 ` Andy Lutomirski
2020-02-14 22:27 ` [PATCH v2 0/7] " Tony Luck
2020-02-14 22:27 ` [PATCH v2 1/7] x86/mce: Rename "first" function as "early" Tony Luck
2020-04-15 9:49 ` [tip: ras/core] " tip-bot2 for Tony Luck
2020-02-14 22:27 ` [PATCH v2 2/7] x86/mce: Convert corrected error collector to use mce notifier Tony Luck
2020-04-15 9:49 ` [tip: ras/core] x86/mce: Convert the CEC to use the MCE notifier tip-bot2 for Tony Luck
2020-02-14 22:27 ` [PATCH v2 3/7] x86/mce: Add new "kflags" field to "struct mce" Tony Luck
2020-04-15 9:49 ` [tip: ras/core] x86/mce: Add a struct mce.kflags field tip-bot2 for Tony Luck
2020-04-15 18:19 ` Luck, Tony
2020-04-15 18:36 ` Borislav Petkov
2020-04-15 19:58 ` [PATCH] x86/mce: Drop bogus comment about mce.kflags Luck, Tony
2020-04-17 9:21 ` [tip: ras/core] " tip-bot2 for Tony Luck
2020-04-20 8:06 ` [tip: ras/core] x86/mce: Add a struct mce.kflags field Christoph Hellwig
2020-04-20 8:42 ` Borislav Petkov
2020-02-14 22:27 ` [PATCH v2 4/7] x86/mce: Fix all mce notifiers to update the mce->kflags bitmask Tony Luck
2020-04-07 8:21 ` Borislav Petkov
2020-04-15 9:49 ` [tip: ras/core] " tip-bot2 for Tony Luck
2020-02-14 22:27 ` [PATCH v2 5/7] x86/mce: Change default mce logger to check mce->kflags Tony Luck
2020-04-07 11:10 ` Borislav Petkov
2020-04-07 16:43 ` Luck, Tony
2020-04-07 19:37 ` Borislav Petkov
2020-04-07 19:44 ` Luck, Tony
2020-04-15 9:49 ` [tip: ras/core] x86/mce: Change default MCE " tip-bot2 for Tony Luck
2020-02-14 22:27 ` [PATCH v2 6/7] x86/mce: Add mce=print_all option Tony Luck
2020-04-15 9:49 ` [tip: ras/core] " tip-bot2 for Tony Luck
2020-02-14 22:27 ` [PATCH v2 7/7] x86/mce: Drop the EDAC report status checks Tony Luck
2020-04-15 9:49 ` [tip: ras/core] EDAC: " tip-bot2 for Tony Luck
2020-04-07 16:34 ` [PATCH 0/9 v3] New way to track mce notifier chain actions Borislav Petkov
2020-04-07 16:34 ` [PATCH 1/9] x86/mce/amd, edac: Remove report_gart_errors Borislav Petkov
2020-04-15 9:49 ` [tip: ras/core] " tip-bot2 for Borislav Petkov
2020-04-07 16:34 ` [PATCH 2/9] x86/mce: Rename "first" function as "early" Borislav Petkov
2020-04-07 16:34 ` [PATCH 3/9] x86/mce: Convert the CEC to use the MCE notifier Borislav Petkov
2020-04-07 16:34 ` [PATCH 4/9] x86/mce: Add a struct mce.kflags field Borislav Petkov
2020-04-07 16:34 ` [PATCH 5/9] x86/mce: Fix all mce notifiers to update the mce->kflags bitmask Borislav Petkov
2020-04-07 16:34 ` [PATCH 6/9] x86/mce: Change default MCE logger to check mce->kflags Borislav Petkov
2020-04-07 16:34 ` [PATCH 7/9] x86/mce: Add mce=print_all option Borislav Petkov
2020-04-07 16:34 ` [PATCH 8/9] EDAC: Drop the EDAC report status checks Borislav Petkov
2020-04-07 16:34 ` [PATCH 9/9] x86/mce: Fixup exception only for the correct MCEs Borislav Petkov
2020-04-15 9:49 ` [tip: ras/core] " tip-bot2 for Borislav Petkov
2020-04-07 19:53 ` [PATCH 0/9 v3] New way to track mce notifier chain actions Luck, Tony
2020-04-07 19:56 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214090537.GF13395@zn.tnic \
--to=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).