From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCCFBC2BA83 for ; Fri, 14 Feb 2020 17:48:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB12A20848 for ; Fri, 14 Feb 2020 17:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581702493; bh=b7WeVWMU18+0j8Oy/dzmg82C976aMJG0iJwWBry31w0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vjZaROiMYsxX5YFgrOGTYIz/Ik6Q+PNWhcichzLnw5Dg4U/vWpgOOYttmnCKYrl+E /j9vDoXyCiQyeSGC/qo4plxlEyEnabmK8dVbh6Pk3phtiaFj6uUE8lAdQ8dKxjmCGn KTwknDBJDf1j375x1aelGeKOwPPTkwU47/rm+Icc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389572AbgBNRsM (ORCPT ); Fri, 14 Feb 2020 12:48:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:44884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388529AbgBNP7w (ORCPT ); Fri, 14 Feb 2020 10:59:52 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D4B0E2086A; Fri, 14 Feb 2020 15:59:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581695991; bh=b7WeVWMU18+0j8Oy/dzmg82C976aMJG0iJwWBry31w0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lceZfoEtyq/cISGNXQqjZf8hUH2DukmsTZ0fUZEyOGjMWkx/v4wOFwLF3+Ee1T+en NmAAPIx5ovskLSCg3dCboDnPEM4KMTCAMECAwoiIt5Gkubpavw4u3OJee9j5EGHU2W qNCj7TUP8NiQHLpG3jYivqNBhXgPO3/YnYhjOFjk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zenghui Yu , Marc Zyngier , Sasha Levin Subject: [PATCH AUTOSEL 5.5 512/542] irqchip/gic-v3-its: Reference to its_invall_cmd descriptor when building INVALL Date: Fri, 14 Feb 2020 10:48:24 -0500 Message-Id: <20200214154854.6746-512-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200214154854.6746-1-sashal@kernel.org> References: <20200214154854.6746-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zenghui Yu [ Upstream commit 107945227ac5d4c37911c7841b27c64b489ce9a9 ] It looks like an obvious mistake to use its_mapc_cmd descriptor when building the INVALL command block. It so far worked by luck because both its_mapc_cmd.col and its_invall_cmd.col sit at the same offset of the ITS command descriptor, but we should not rely on it. Fixes: cc2d3216f53c ("irqchip: GICv3: ITS command queue") Signed-off-by: Zenghui Yu Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20191202071021.1251-1-yuzenghui@huawei.com Signed-off-by: Sasha Levin --- drivers/irqchip/irq-gic-v3-its.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index b704214390c0f..50f89056c16bb 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -598,7 +598,7 @@ static struct its_collection *its_build_invall_cmd(struct its_node *its, struct its_cmd_desc *desc) { its_encode_cmd(cmd, GITS_CMD_INVALL); - its_encode_collection(cmd, desc->its_mapc_cmd.col->col_id); + its_encode_collection(cmd, desc->its_invall_cmd.col->col_id); its_fixup_cmd(cmd); -- 2.20.1