From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C271AC47409 for ; Fri, 14 Feb 2020 16:04:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9389A24676 for ; Fri, 14 Feb 2020 16:04:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581696281; bh=j10t5HO3W2ltOm3+De7grvLgQUA7DCKNukRC3XW6FKE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=g8eRvEntRR2hiYzhmib08NXD5bqpo8IwWXMNUHgp3ECUz6Knpk76BuYes/IsNPH7/ 9hWXifcCYsMkGT6l5HxNJyM6TRdEAove3FBWchv6q+p2EMrLrAPgS0dECT5G1suEo4 3+zRPXUTNWvgi4fPaiFjmKccWMiJRaURgenBrbJk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389482AbgBNQEl (ORCPT ); Fri, 14 Feb 2020 11:04:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:52206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389878AbgBNQEQ (ORCPT ); Fri, 14 Feb 2020 11:04:16 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 97CBA2067D; Fri, 14 Feb 2020 16:04:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581696255; bh=j10t5HO3W2ltOm3+De7grvLgQUA7DCKNukRC3XW6FKE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rxekAY//VSeIxkmZLugavn6R5Bb+P2NAnY86mAAamx/qo893OonWeg6wjUb2WDuRW 6WQKJaslOIfIDH9aUR0cnufeyZO+FhwRVSepSYNjnTpHLu7z3XAlgplQCHNT2zn0Cv O4L52NHuz/IVH0RBZ4pu7crO5t3KjzVou3/yWWB8= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Masahiro Yamada , Vincenzo Frascino , Sasha Levin , linux-kbuild@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 110/459] kconfig: fix broken dependency in randconfig-generated .config Date: Fri, 14 Feb 2020 10:56:00 -0500 Message-Id: <20200214160149.11681-110-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200214160149.11681-1-sashal@kernel.org> References: <20200214160149.11681-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Masahiro Yamada [ Upstream commit c8fb7d7e48d11520ad24808cfce7afb7b9c9f798 ] Running randconfig on arm64 using KCONFIG_SEED=0x40C5E904 (e.g. on v5.5) produces the .config with CONFIG_EFI=y and CONFIG_CPU_BIG_ENDIAN=y, which does not meet the !CONFIG_CPU_BIG_ENDIAN dependency. This is because the user choice for CONFIG_CPU_LITTLE_ENDIAN vs CONFIG_CPU_BIG_ENDIAN is set by randomize_choice_values() after the value of CONFIG_EFI is calculated. When this happens, the has_changed flag should be set. Currently, it takes the result from the last iteration. It should accumulate all the results of the loop. Fixes: 3b9a19e08960 ("kconfig: loop as long as we changed some symbols in randconfig") Reported-by: Vincenzo Frascino Signed-off-by: Masahiro Yamada Signed-off-by: Sasha Levin --- scripts/kconfig/confdata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c index 3569d2dec37ce..17298239e3633 100644 --- a/scripts/kconfig/confdata.c +++ b/scripts/kconfig/confdata.c @@ -1353,7 +1353,7 @@ bool conf_set_all_new_symbols(enum conf_def_mode mode) sym_calc_value(csym); if (mode == def_random) - has_changed = randomize_choice_values(csym); + has_changed |= randomize_choice_values(csym); else { set_all_choice_values(csym); has_changed = true; -- 2.20.1