From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2310BC2BA83 for ; Fri, 14 Feb 2020 17:16:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E048E20637 for ; Fri, 14 Feb 2020 17:16:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581700619; bh=dfkQTTlWdh9yeBtr6FQzHpZfrJDgKsq5R03253NZN1g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xMj+DqOlHJg3D0d/rkx7GAcVXa0KupDnkLeN3Afd/43yIoqkp2UrkF+WTC2L91rWn 3XrqltgyU8a204CbhRyvS7ieu5tDIqH0Z0V2XFbNWwNYWWzsJ+Z9Vj18IASsywkkwO 2ulhjA/uSjHAMitHLGpz1BsciMqg9w6dcQXxocLc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391800AbgBNQLa (ORCPT ); Fri, 14 Feb 2020 11:11:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:36322 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391538AbgBNQKe (ORCPT ); Fri, 14 Feb 2020 11:10:34 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 105942468F; Fri, 14 Feb 2020 16:10:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581696634; bh=dfkQTTlWdh9yeBtr6FQzHpZfrJDgKsq5R03253NZN1g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UhG3TBtFdrEO/hdFqJKTu6TZtNquWwjFysJqY76O8DikMpMDxoiLAtHHe3FnmLRJi ++vJfpFCmAqcjOsGq8L5RmXUYrZW+yIxncrWMZ2toXvUMA11jsObFNoIUfo5Ygsota HvNzA46dmPg7nvNF2ftq3y7meO0Ms4xV9BXK2oB4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Steve French , Colin Ian King , Paulo Alcantara , Sasha Levin , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org Subject: [PATCH AUTOSEL 5.4 412/459] cifs: fix unitialized variable poential problem with network I/O cache lock patch Date: Fri, 14 Feb 2020 11:01:02 -0500 Message-Id: <20200214160149.11681-412-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200214160149.11681-1-sashal@kernel.org> References: <20200214160149.11681-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steve French [ Upstream commit 463a7b457c02250a84faa1d23c52da9e3364aed2 ] static analysis with Coverity detected an issue with the following commit: Author: Paulo Alcantara (SUSE) Date: Wed Dec 4 17:38:03 2019 -0300 cifs: Avoid doing network I/O while holding cache lock Addresses-Coverity: ("Uninitialized pointer read") Reported-by: Colin Ian King Signed-off-by: Paulo Alcantara (SUSE) Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/cifs/dfs_cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c index 2faa05860a483..cf6cec59696c2 100644 --- a/fs/cifs/dfs_cache.c +++ b/fs/cifs/dfs_cache.c @@ -1319,7 +1319,7 @@ static struct cifs_ses *find_root_ses(struct dfs_cache_vol_info *vi, char *mdata = NULL, *devname = NULL; struct TCP_Server_Info *server; struct cifs_ses *ses; - struct smb_vol vol; + struct smb_vol vol = {NULL}; rpath = get_dfs_root(path); if (IS_ERR(rpath)) -- 2.20.1