From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48143C3B19F for ; Fri, 14 Feb 2020 16:32:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 204A5246A1 for ; Fri, 14 Feb 2020 16:32:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="DGtJGdns" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406681AbgBNQc0 (ORCPT ); Fri, 14 Feb 2020 11:32:26 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:46302 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393515AbgBNQcX (ORCPT ); Fri, 14 Feb 2020 11:32:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=EVE2QyhWUcN4faOpoE+Hy0shAp6QLvkX+MzRUb+BF8o=; b=DGtJGdns92ALhj0LSBlHNMtF6I DhAVpF8S7uZJn68IIMdm5g7arm1DSs0SWj7Amd4JzBs7bUmEUo/exo8CrdC8PyDeRRLSst8j7eoCi 9IETsM3kUrmjRbteV9lFAM1gS/qNFrporaX9mIi83Yd7vypiemAz2aZPpdmSK7V00J08=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1j2dsr-0000Hl-9O; Fri, 14 Feb 2020 17:32:05 +0100 Date: Fri, 14 Feb 2020 17:32:05 +0100 From: Andrew Lunn To: "H. Nikolaus Schaller" Cc: Paul Cercueil , "David S. Miller" , Petr =?utf-8?Q?=C5=A0tetiar?= , Richard Fontana , Thomas Gleixner , Heiner Kallweit , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com Subject: Re: [PATCH v2] net: davicom: dm9000: allow to pass MAC address through mac_addr module parameter Message-ID: <20200214163205.GL31084@lunn.ch> References: <0d6b4d383bb29ed5d4710e9706e5ad6c7f92d9da.1581696454.git.hns@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d6b4d383bb29ed5d4710e9706e5ad6c7f92d9da.1581696454.git.hns@goldelico.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 14, 2020 at 05:07:35PM +0100, H. Nikolaus Schaller wrote: > The MIPS Ingenic CI20 board is shipped with a quite old u-boot > (ci20-v2013.10 see https://elinux.org/CI20_Dev_Zone). This passes > the MAC address through dm9000.mac_addr=xx:xx:xx:xx:xx:xx > kernel module parameter to give the board a fixed MAC address. I think this will get ACKed. There is a well defined way to pass the MAC address via DT. The driver supports that already. uboot for this board appears to be open: https://github.com/MIPS/CI20_u-boot and it is documented to how build it. So there is no reason why it cannot be made to support the standard mechanism. Andrew