From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96294C2BA83 for ; Fri, 14 Feb 2020 17:40:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79FF52168B for ; Fri, 14 Feb 2020 17:40:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730835AbgBNRkX (ORCPT ); Fri, 14 Feb 2020 12:40:23 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:48307 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729435AbgBNRkV (ORCPT ); Fri, 14 Feb 2020 12:40:21 -0500 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2ewq-0003Dk-PF; Fri, 14 Feb 2020 18:40:16 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1j2ewo-0000El-ND; Fri, 14 Feb 2020 18:40:14 +0100 Date: Fri, 14 Feb 2020 18:40:14 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, yu kuai , Thierry Reding , linux-pwm@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.5 418/542] pwm: Remove set but not set variable 'pwm' Message-ID: <20200214174014.lfnhsl6d7nyfkfbm@pengutronix.de> References: <20200214154854.6746-1-sashal@kernel.org> <20200214154854.6746-418-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200214154854.6746-418-sashal@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Sasha, On Fri, Feb 14, 2020 at 10:46:50AM -0500, Sasha Levin wrote: > From: yu kuai > > [ Upstream commit 9871abffc81048e20f02e15d6aa4558a44ad53ea ] > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/pwm/pwm-pca9685.c: In function ‘pca9685_pwm_gpio_free’: > drivers/pwm/pwm-pca9685.c:162:21: warning: variable ‘pwm’ set but not used [-Wunused-but-set-variable] > > It is never used, and so can be removed. In that case, hold and release > the lock 'pca->lock' can be removed since nothing will be done between > them. > > Fixes: e926b12c611c ("pwm: Clear chip_data in pwm_put()") > Signed-off-by: yu kuai > Acked-by: Uwe Kleine-König > Signed-off-by: Thierry Reding > Signed-off-by: Sasha Levin > --- > drivers/pwm/pwm-pca9685.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c > index 168684b02ebce..b07bdca3d510d 100644 > --- a/drivers/pwm/pwm-pca9685.c > +++ b/drivers/pwm/pwm-pca9685.c > @@ -159,13 +159,9 @@ static void pca9685_pwm_gpio_set(struct gpio_chip *gpio, unsigned int offset, > static void pca9685_pwm_gpio_free(struct gpio_chip *gpio, unsigned int offset) > { > struct pca9685 *pca = gpiochip_get_data(gpio); > - struct pwm_device *pwm; > > pca9685_pwm_gpio_set(gpio, offset, 0); > pm_runtime_put(pca->chip.dev); > - mutex_lock(&pca->lock); > - pwm = &pca->chip.pwms[offset]; > - mutex_unlock(&pca->lock); Even though I bet this change won't introduce a regression, it only fixes a harmless warning. So I wonder if it objectively qualifies to be applied for stable. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |