[PATCH 0/2] phy: ti: gmii-sel: two fixes

[PATCH 0/2] phy: ti: gmii-sel: two fixes

[Grygorii Strashko]

Hi Kishon,

Here the two minor fixes for TI phy-gmii-sel PHY.
 - Patch 1: few minor copy-paste errors.
 - Patch 2: enables back gmii mode (not used now, so no issues reported til now)

Grygorii Strashko (2):
  phy: ti: gmii-sel: fix set of copy-paste errors
  phy: ti: gmii-sel: do not fail in case of gmii

 drivers/phy/ti/phy-gmii-sel.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

-- 
2.17.1

[PATCH 1/2] phy: ti: gmii-sel: fix set of copy-paste errors

[Grygorii Strashko]

- under PHY_INTERFACE_MODE_MII the 'mode' func parameter is assigned
instead of 'gmii_sel_mode' and it's working only because the default value
'gmii_sel_mode' is set to 0.

- console outputs use 'rgmii_id' and 'mode' values to print PHY mode
instead of using 'submode' value which is representing PHY interface mode
now.

This patch fixes above two cases.

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 drivers/phy/ti/phy-gmii-sel.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/phy/ti/phy-gmii-sel.c b/drivers/phy/ti/phy-gmii-sel.c
index a28bd15297f5..e998e9cd8d1f 100644
--- a/drivers/phy/ti/phy-gmii-sel.c
+++ b/drivers/phy/ti/phy-gmii-sel.c
@@ -80,20 +80,19 @@ static int phy_gmii_sel_mode(struct phy *phy, enum phy_mode mode, int submode)
 		break;
 
 	case PHY_INTERFACE_MODE_MII:
-		mode = AM33XX_GMII_SEL_MODE_MII;
+		gmii_sel_mode = AM33XX_GMII_SEL_MODE_MII;
 		break;
 
 	default:
-		dev_warn(dev,
-			 "port%u: unsupported mode: \"%s\". Defaulting to MII.\n",
-			 if_phy->id, phy_modes(rgmii_id));
+		dev_warn(dev, "port%u: unsupported mode: \"%s\"\n",
+			 if_phy->id, phy_modes(submode));
 		return -EINVAL;
 	}
 
 	if_phy->phy_if_mode = submode;
 
 	dev_dbg(dev, "%s id:%u mode:%u rgmii_id:%d rmii_clk_ext:%d\n",
-		__func__, if_phy->id, mode, rgmii_id,
+		__func__, if_phy->id, submode, rgmii_id,
 		if_phy->rmii_clock_external);
 
 	regfield = if_phy->fields[PHY_GMII_SEL_PORT_MODE];
-- 
2.17.1

[PATCH 2/2] phy: ti: gmii-sel: do not fail in case of gmii

[Grygorii Strashko]

The "gmii" PHY interface mode is supported on TI AM335x/437x/5xx SoCs, so
don't fail if it's selected.

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 drivers/phy/ti/phy-gmii-sel.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/ti/phy-gmii-sel.c b/drivers/phy/ti/phy-gmii-sel.c
index e998e9cd8d1f..1c536fc03c83 100644
--- a/drivers/phy/ti/phy-gmii-sel.c
+++ b/drivers/phy/ti/phy-gmii-sel.c
@@ -80,6 +80,7 @@ static int phy_gmii_sel_mode(struct phy *phy, enum phy_mode mode, int submode)
 		break;
 
 	case PHY_INTERFACE_MODE_MII:
+	case PHY_INTERFACE_MODE_GMII:
 		gmii_sel_mode = AM33XX_GMII_SEL_MODE_MII;
 		break;
 
-- 
2.17.1

Re: [PATCH 0/2] phy: ti: gmii-sel: two fixes

[Kishon Vijay Abraham I]

On 15/02/20 12:37 am, Grygorii Strashko wrote:
> Hi Kishon,
> 
> Here the two minor fixes for TI phy-gmii-sel PHY.
>  - Patch 1: few minor copy-paste errors.
>  - Patch 2: enables back gmii mode (not used now, so no issues reported til now)
> 
> Grygorii Strashko (2):
>   phy: ti: gmii-sel: fix set of copy-paste errors
>   phy: ti: gmii-sel: do not fail in case of gmii

merged, thanks!

-Kishon
> 
>  drivers/phy/ti/phy-gmii-sel.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>