From: Masahiro Yamada <masahiroy@kernel.org>
To: x86@kernel.org, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, "H . Peter Anvin" <hpa@zytor.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>,
Bruce Ashfield <bruce.ashfield@gmail.com>,
Daniel Kiper <daniel.kiper@oracle.com>,
Ingo Molnar <mingo@redhat.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Ross Burton <ross.burton@intel.com>,
Ross Philipson <ross.philipson@oracle.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] x86/boot/build: add phony targets in arch/x86/boot/Makefile to PHONY
Date: Sat, 15 Feb 2020 15:38:52 +0900 [thread overview]
Message-ID: <20200215063852.8298-2-masahiroy@kernel.org> (raw)
In-Reply-To: <20200215063852.8298-1-masahiroy@kernel.org>
These targets are correctly added to PHONY in arch/x86/Makefile, but
you need do so in arch/x86/boot/Makefile, too.
Otherwise, if you have a file 'install' in the top directory,
'make install' does nothing.
$ touch install
$ make install
make[1]: 'install' is up to date.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/x86/boot/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
index 1b37746aab82..fc889bcfc2f8 100644
--- a/arch/x86/boot/Makefile
+++ b/arch/x86/boot/Makefile
@@ -127,6 +127,8 @@ quiet_cmd_genimage = GENIMAGE $3
cmd_genimage = sh $(srctree)/$(src)/genimage.sh $2 $3 $(obj)/bzImage \
$(obj)/mtools.conf '$(image_cmdline)' $(FDINITRD)
+PHONY += bzdisk fdimage fdimage144 fdimage288 isoimage bzlilo install
+
# This requires write access to /dev/fd0
bzdisk: $(obj)/bzImage $(obj)/mtools.conf
$(call cmd,genimage,bzdisk,/dev/fd0)
--
2.17.1
next prev parent reply other threads:[~2020-02-15 6:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 6:38 [PATCH 1/2] x86/boot/build: make 'make bzlilo' not depend on vmlinux or $(obj)/bzImage Masahiro Yamada
2020-02-15 6:38 ` Masahiro Yamada [this message]
2020-04-21 18:30 ` [tip: x86/build] x86/boot/build: Add phony targets in arch/x86/boot/Makefile to PHONY tip-bot2 for Masahiro Yamada
2020-03-30 6:40 ` [PATCH 1/2] x86/boot/build: make 'make bzlilo' not depend on vmlinux or $(obj)/bzImage Masahiro Yamada
2020-04-21 18:30 ` [tip: x86/build] x86/boot/build: Make " tip-bot2 for Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200215063852.8298-2-masahiroy@kernel.org \
--to=masahiroy@kernel.org \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=bruce.ashfield@gmail.com \
--cc=daniel.kiper@oracle.com \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=ross.burton@intel.com \
--cc=ross.philipson@oracle.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).