From: Jason Gunthorpe <jgg@ziepe.ca>
To: Maxim Mikityanskiy <maximmi@mellanox.com>
Cc: Alexander Lobakin <alobakin@dlink.ru>,
Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>,
Yishai Hadas <yishaih@mellanox.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH rdma] IB/mlx5: Fix linkage failure on 32-bit arches
Date: Sun, 16 Feb 2020 20:36:10 -0400 [thread overview]
Message-ID: <20200217003610.GC31668@ziepe.ca> (raw)
In-Reply-To: <3c70c7da-60aa-10ec-767f-5e519357b8e6@mellanox.com>
On Sun, Feb 16, 2020 at 01:53:50PM +0200, Maxim Mikityanskiy wrote:
> On 2020-02-14 21:44, Alexander Lobakin wrote:
> > Jason Gunthorpe wrote 14.02.2020 22:24:
> > > On Fri, Feb 14, 2020 at 10:13:09PM +0300, Alexander Lobakin wrote:
> > > > Commit f164be8c0366 ("IB/mlx5: Extend caps stage to handle VAR
> > > > capabilities") introduced a straight "/" division of the u64
> > > > variable "bar_size", which emits an __udivdi3() libgcc call on
> > > > 32-bit arches and certain GCC versions:
> > > >
> > > > error: "__udivdi3" [drivers/infiniband/hw/mlx5/mlx5_ib.ko]
> > > > undefined! [1]
> > > >
> > > > Replace it with the corresponding div_u64() call.
> > > > Compile-tested on ARCH=mips 32r2el_defconfig BOARDS=ocelot.
> > > >
> > > > [1] https://lore.kernel.org/linux-mips/CAMuHMdXM9S1VkFMZ8eDAyZR6EE4WkJY215Lcn2qdOaPeadF+EQ@mail.gmail.com/
> > > >
> > > >
> > > > Fixes: f164be8c0366 ("IB/mlx5: Extend caps stage to handle VAR
> > > > capabilities")
> > > > Signed-off-by: Alexander Lobakin <alobakin@dlink.ru>
> > > > drivers/infiniband/hw/mlx5/main.c | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > Randy beat you too it..
> > >
> > > https://lore.kernel.org/linux-rdma/20200206143201.GF25297@ziepe.ca/
> >
> > Ah, OK. Sorry for missing this one. I didn't see any fix over
> > git.kernel.org and thought it doesn't exist yet.
> >
> > > But it seems patchwork missed this somehow.
> > >
> > > Applied now at least
>
> Jason, I think Alexander's patch is more correct. It uses div_u64, while
> yours uses div64_u64. The divider is 32-bit, so div_u64 would be more
> optimized on most 32-bit architectures.
Seems so, but it is already done. You can send a followup to fix it
Jason
prev parent reply other threads:[~2020-02-17 0:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 19:13 [PATCH rdma] IB/mlx5: Fix linkage failure on 32-bit arches Alexander Lobakin
2020-02-14 19:24 ` Jason Gunthorpe
2020-02-14 19:44 ` Alexander Lobakin
2020-02-16 11:53 ` Maxim Mikityanskiy
2020-02-17 0:36 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217003610.GC31668@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=alobakin@dlink.ru \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maximmi@mellanox.com \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).