linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Maennich <maennich@google.com>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: Quentin Perret <qperret@google.com>,
	masahiroy@kernel.org, linux-kernel@vger.kernel.org,
	linux-kbuild@vger.kernel.org, kernel-team@android.com,
	jeyu@kernel.org, hch@infradead.org
Subject: Re: [PATCH v4 1/3] kbuild: allow symbol whitelisting with TRIM_UNUSED_KSYMS
Date: Mon, 17 Feb 2020 16:35:40 +0000	[thread overview]
Message-ID: <20200217163540.GD48466@google.com> (raw)
In-Reply-To: <nycvar.YSQ.7.76.2002171059230.1559@knanqh.ubzr>

On Mon, Feb 17, 2020 at 11:00:39AM -0500, Nicolas Pitre wrote:
>On Mon, 17 Feb 2020, Quentin Perret wrote:
>
>> On Monday 17 Feb 2020 at 15:22:01 (+0000), Matthias Maennich wrote:
>> > In case the whitelist file can't be found, the error message is
>> >
>> >  cat: path/to/file: file not found
>> >
>> > I wonder whether we can make this error message a bit more specific by
>> > telling the user that the KSYMS_WHITELIST is missing.
>>
>> +1, that'd be really useful. I'll check the file existence in v5 (in a
>> POSIX-compliant way, I promise).
>
>In fact, if you explicitly provide a file that is not there, then this
>is arguably a good reason to even fail the build.

I agree, I would expect the build to fail in that case.

Cheers,
Matthias

>
>
>Nicolas

  reply	other threads:[~2020-02-17 16:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 20:21 [PATCH v4 0/3] kbuild: allow symbol whitelisting with TRIM_UNUSED_KSYM Quentin Perret
2020-02-12 20:21 ` [PATCH v4 1/3] kbuild: allow symbol whitelisting with TRIM_UNUSED_KSYMS Quentin Perret
2020-02-17 14:23   ` Quentin Perret
2020-02-17 15:22   ` Matthias Maennich
2020-02-17 15:30     ` Quentin Perret
2020-02-17 16:00       ` Nicolas Pitre
2020-02-17 16:35         ` Matthias Maennich [this message]
2020-02-12 20:21 ` [PATCH v4 2/3] kbuild: split adjust_autoksyms.sh in two parts Quentin Perret
2020-02-17 15:37   ` Matthias Maennich
2020-02-12 20:21 ` [PATCH v4 3/3] kbuild: generate autoksyms.h early Quentin Perret
2020-02-17 16:34   ` Matthias Maennich
2020-02-12 20:48 ` [PATCH v4 0/3] kbuild: allow symbol whitelisting with TRIM_UNUSED_KSYM Nicolas Pitre
2020-02-12 20:53   ` Quentin Perret

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200217163540.GD48466@google.com \
    --to=maennich@google.com \
    --cc=hch@infradead.org \
    --cc=jeyu@kernel.org \
    --cc=kernel-team@android.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nico@fluxnic.net \
    --cc=qperret@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).