From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 084B3C34021 for ; Mon, 17 Feb 2020 17:30:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD22B20658 for ; Mon, 17 Feb 2020 17:30:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581960654; bh=lUOr/P7Co+hhxw3FCW0w5zsARxmb/fCKtBS8bbYtmB8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Qbh4ttw9f/XsjkggnCTzYLpwguQ/VxPK4ivDcsCaPnt1nSQwocGYyXwpVxaMzSm6j 6ggwQol17de2w2aJb+CLYLg3hxOBny5ExVRbDixjFA67rm+Xkp1McKtUGs70v9SCYN H4j+FSXh4de++2YaIPbjT/n0RHdBHei3DJO9HM1s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729716AbgBQRax (ORCPT ); Mon, 17 Feb 2020 12:30:53 -0500 Received: from foss.arm.com ([217.140.110.172]:39088 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728706AbgBQRax (ORCPT ); Mon, 17 Feb 2020 12:30:53 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AAC091FB; Mon, 17 Feb 2020 09:30:52 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2DD893F68F; Mon, 17 Feb 2020 09:30:52 -0800 (PST) Date: Mon, 17 Feb 2020 17:30:50 +0000 From: Mark Brown To: Stephan Gerhold Cc: Sameer Pujar , tiwai@suse.com, perex@perex.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jerome Brunet Subject: Re: [alsa-devel] [RFC] ASoC: soc-pcm: crash in snd_soc_dapm_new_dai Message-ID: <20200217173050.GT9304@sirena.org.uk> References: <1579443563-12287-1-git-send-email-spujar@nvidia.com> <20200217144120.GA243254@gerhold.net> <20200217154301.GN9304@sirena.org.uk> <20200217171245.GA881@gerhold.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ceuyUbi+oA5bUa/n" Content-Disposition: inline In-Reply-To: <20200217171245.GA881@gerhold.net> X-Cookie: There was a phone call for you. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ceuyUbi+oA5bUa/n Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 17, 2020 at 06:12:45PM +0100, Stephan Gerhold wrote: > This does the swapping you mentioned, so I guess rtd->dai_link->params > is only set for the codec2codec case? Yes, that's the idea. > From my limited understanding, I would say that a much simpler way to > implement this would be: >=20 > But I'm really not familar with the codec2codec case and am unable to > test it :) What do you think? I think that looks reasonable from just looking at the e-mail without a context diff and you should submit a patch so others can test! --ceuyUbi+oA5bUa/n Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5KzckACgkQJNaLcl1U h9BziAf+Izx20KRsb99onN4hjg2gDkeh3TMcutoOsbRYWWFaMSJOZ9Fq+lHXbuIq 0Qx4gzYh6jMLzvOPDY4BDyzSmcmE/7nAsAhNguMyc936iDrxG/K66Mq7sDX8oL45 YRWofbhaO4GvVtlpz1hxcrLrVVR9B3a2XreUqqmZQM2jLZCwgPtU0xALL/IDEwyb VL/OCGwh3GfX3DTmsarJCj3tUlwKcvN9QdS5p4KQvH1q18D9O9nd/I0ykSrkbjPt 6wN2fEAxsfbHRoEbfmGZ3kCXVe7pxLRGiCe13e3ea17uv/Z9u95bHgBRIJVNEcSV MX62HJ6YUZFKc/aAcg2f6BBGnaYpXQ== =BVkC -----END PGP SIGNATURE----- --ceuyUbi+oA5bUa/n--