From: Boris Brezillon <boris.brezillon@collabora.com>
To: Schrempf Frieder <frieder.schrempf@kontron.de>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
Jeff Kletsky <git-commits@allycomm.com>,
liaoweixiong <liaoweixiong@allwinnertech.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] mtd: spinand: Don not erase the block before writing a bad block marker
Date: Mon, 17 Feb 2020 18:24:38 +0100 [thread overview]
Message-ID: <20200217182438.76a25592@collabora.com> (raw)
In-Reply-To: <20200217155213.5594-4-frieder.schrempf@kontron.de>
In the subject: s/Don not/Do not/
On Mon, 17 Feb 2020 15:54:12 +0000
Schrempf Frieder <frieder.schrempf@kontron.de> wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> Currently when marking a block, we use spinand_erase_op() to erase
> the block before writing the marker to the OOB area. Doing so without
> waiting for the operation to finish can lead to the marking failing
> silently and no bad block marker being written to the flash.
>
> In fact we don't need to do an erase at all before writing the BBM.
> The ECC is disabled for the raw access to the OOB data and we don't
s/the raw access/raw accesses/
> need to work around any issues with chips reporting ECC errors as it
> is known to be the case for raw NAND.
>
> Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs")
> Cc: stable@vger.kernel.org
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> Changes in v2:
> * Instead of waiting for the erase operation to finish, just don't
> do an erase at all, as it is not needed.
> * Update the commit message
> ---
> drivers/mtd/nand/spi/core.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
> index a94287884453..8dda51bbdd11 100644
> --- a/drivers/mtd/nand/spi/core.c
> +++ b/drivers/mtd/nand/spi/core.c
> @@ -613,7 +613,6 @@ static int spinand_markbad(struct nand_device *nand, const struct nand_pos *pos)
> };
> int ret;
>
> - /* Erase block before marking it bad. */
> ret = spinand_select_target(spinand, pos->target);
> if (ret)
> return ret;
> @@ -622,8 +621,6 @@ static int spinand_markbad(struct nand_device *nand, const struct nand_pos *pos)
> if (ret)
> return ret;
>
> - spinand_erase_op(spinand, pos);
> -
> return spinand_write_page(spinand, &req);
> }
>
prev parent reply other threads:[~2020-02-17 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 15:53 [PATCH v2 0/3] mtd: spinand: Fix reading and writing of bad block markers Schrempf Frieder
2020-02-17 15:53 ` [PATCH v2 1/3] mtd: spinand: Stop using spinand->oobbuf for buffering " Schrempf Frieder
2020-02-17 15:54 ` [PATCH v2 2/3] mtd: spinand: Explicitly use MTD_OPS_RAW to write the bad block marker to OOB Schrempf Frieder
2020-02-17 15:54 ` [PATCH v2 3/3] mtd: spinand: Don not erase the block before writing a bad block marker Schrempf Frieder
2020-02-17 17:24 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217182438.76a25592@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=bbrezillon@kernel.org \
--cc=frieder.schrempf@kontron.de \
--cc=git-commits@allycomm.com \
--cc=liaoweixiong@allwinnertech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).