From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75E89C34026 for ; Tue, 18 Feb 2020 09:43:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4EFDF24125 for ; Tue, 18 Feb 2020 09:43:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="M3nUbsAp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726767AbgBRJnV (ORCPT ); Tue, 18 Feb 2020 04:43:21 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:54425 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726539AbgBRJnC (ORCPT ); Tue, 18 Feb 2020 04:43:02 -0500 Received: by mail-wm1-f66.google.com with SMTP id g1so2037026wmh.4 for ; Tue, 18 Feb 2020 01:43:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eTkQGJDWHefZVFi7RvLf325NQF5TV4xQSrTAWKaZFp4=; b=M3nUbsApTLVf49s8cy3nMBX1nddz/hkUmLgOaxMGMvvDCJ6+R6U9faEHshl8EUoNlv tcose4CB7DhkO6IY4d8exh6bM6efO19LG98uJgBf8Mvfp3F5QigRv6qPR4bEMcdrWuhv eOImUbdFYpWSCGp3Fa7fYxVhjNlaMS0RjODnskvR8BvKe3eJpyilPS7aI8HaCWaOv7K9 e+5Cx5Jx3D/ONhhTeqXFYuBU0P6M+ILNTOKCKNzYj43qx1Z+ooWu5Tq0CuKvidZ6pMcL VdNOXq0OuTHEZcjfT6cE1WKnPCZXUO2H4MIwtSONsrC8kAxdpS+RxiBYOrYRbTEpH6I2 jPiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eTkQGJDWHefZVFi7RvLf325NQF5TV4xQSrTAWKaZFp4=; b=ShGTi0Nx1Cm/c1FqtxEJIiYZohUiVNAR3Pzng5e+TL0gpqt2EswoZ64HqR2MmUR6kq KF14xnX3V5y2oVQmT6jBXej2gZP74QJOquEngK4QRMNyldvwa7s2m42Fo//sqoHS7wCF rgP8wSPUBkaoetqsT0kqTwuGEJfK37WUZubBTfhCQAP/c+aMN5awO/6yRqZNsJsbsJqR NcYXkyZXWgVMc0/nug2pfUIXOLmkuzNc5xR7re+3mmLTn6zl715cJSeb+kCpmJ2k9dGE JNKgvj5zsGHrPbF5GRD7e0AMSufsAYekc94J4dUbCU/lVHvHGZ+er57ycyfHRGAyiEBL xHVg== X-Gm-Message-State: APjAAAVom9FaCW3SdyXJiDbjPbmDU+7wcG0rofoQH4qevD38aY/O3SYJ Q4idj0dBGZwDxduw5xamgr0Ztg== X-Google-Smtp-Source: APXvYqxmnog8aASC+4y9wrZ3h35yPUZh6IlfiebH1vUwPi+nhEPx1wxiFrENY24BdELCvaR77onviw== X-Received: by 2002:a7b:c0c7:: with SMTP id s7mr2198987wmh.129.1582018980880; Tue, 18 Feb 2020 01:43:00 -0800 (PST) Received: from localhost.localdomain (lfbn-nic-1-188-94.w2-15.abo.wanadoo.fr. [2.15.37.94]) by smtp.gmail.com with ESMTPSA id s23sm5351095wra.15.2020.02.18.01.43.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 01:43:00 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij , Srinivas Kandagatla , Khouloud Touil , Geert Uytterhoeven Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v2 4/7] nvmem: increase the reference count of a gpio passed over config Date: Tue, 18 Feb 2020 10:42:31 +0100 Message-Id: <20200218094234.23896-5-brgl@bgdev.pl> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200218094234.23896-1-brgl@bgdev.pl> References: <20200218094234.23896-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski We can obtain the write-protect GPIO in nvmem_register() by requesting it ourselves or by storing the gpio_desc passed in nvmem_config. In the latter case we need to increase the reference count so that it gets freed correctly. Signed-off-by: Bartosz Golaszewski --- drivers/nvmem/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index c9b3f4047154..c4a6c044b020 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -346,7 +346,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) if (rval < 0) goto err_free_nvmem; if (config->wp_gpio) - nvmem->wp_gpio = config->wp_gpio; + nvmem->wp_gpio = gpiod_ref(config->wp_gpio); else nvmem->wp_gpio = gpiod_get_optional(config->dev, "wp", GPIOD_OUT_HIGH); -- 2.25.0