From: Bjorn Helgaas <helgaas@kernel.org>
To: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: Stack trace when removing Thunderbolt devices while kernel shutting down
Date: Tue, 18 Feb 2020 08:22:43 -0600 [thread overview]
Message-ID: <20200218142243.GA190321@google.com> (raw)
In-Reply-To: <PSXP216MB0438220243C0097569D4B2DB80110@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
On Tue, Feb 18, 2020 at 02:18:40PM +0000, Nicholas Johnson wrote:
> Hi Bjorn,
>
> If I surprise remove Thunderbolt 3 devices just as the kernel is
> shutting down, I get stack dumps, when those devices would not normally
> cause stack dumps if the kernel were not shutting down.
>
> Because the kernel is shutting down, it makes it difficult to capture
> the logs without a serial console.
>
> In your mind, is this cause for concern? There is no harm caused and the
> kernel still shuts down. The main thing I am worried about is if this
> means that the locking around the subsystem is not strict enough.
>
> If you think this is worth looking into, I will try to learn about how
> the native interrupts are handled and try to investigate, and I will
> also try to get my serial console working again to capture the details.
Yes, I think this is worth looking into.
next prev parent reply other threads:[~2020-02-18 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 14:18 Stack trace when removing Thunderbolt devices while kernel shutting down Nicholas Johnson
2020-02-18 14:22 ` Bjorn Helgaas [this message]
2020-02-18 15:01 ` Lukas Wunner
2020-02-18 16:57 ` Nicholas Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218142243.GA190321@google.com \
--to=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nicholas.johnson-opensource@outlook.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).