From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68167C34044 for ; Tue, 18 Feb 2020 15:34:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 474FC21D56 for ; Tue, 18 Feb 2020 15:34:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726697AbgBRPee (ORCPT ); Tue, 18 Feb 2020 10:34:34 -0500 Received: from muru.com ([72.249.23.125]:55968 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726373AbgBRPee (ORCPT ); Tue, 18 Feb 2020 10:34:34 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id F4223812F; Tue, 18 Feb 2020 15:35:16 +0000 (UTC) Date: Tue, 18 Feb 2020 07:34:29 -0800 From: Tony Lindgren To: Peter Ujfalusi Cc: Kuninori Morimoto , Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Aaro Koskinen , "Arthur D ." , Jarkko Nikula , Merlijn Wajer , Pavel Machek , Sebastian Reichel Subject: Re: [PATCH] ASoC: ti: Allocate dais dynamically for TDM and audio graph card Message-ID: <20200218153429.GJ35972@atomide.com> References: <20200211171645.41990-1-tony@atomide.com> <20200212143543.GI64767@atomide.com> <346dfd2b-23f8-87e0-6f45-27a5099b1066@ti.com> <20200214170322.GZ64767@atomide.com> <20200217231001.GC35972@atomide.com> <20200217233623.GE35972@atomide.com> <07989190-e110-13c4-50ea-875431725b47@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <07989190-e110-13c4-50ea-875431725b47@ti.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Ujfalusi [200218 15:28]: > > > On 18/02/2020 1.36, Tony Lindgren wrote: > > * Tony Lindgren [200217 23:10]: > >> * Peter Ujfalusi [200217 12:10]: > >>> On 14/02/2020 19.03, Tony Lindgren wrote: > >>>> But right now in droid4 voice call case mcbsp is just the i2s transport, > >>>> and everything happens betwee the modem and the cpcap pmic. > >>> > >>> Iow you don't need McBSP DAI at all. If you would have added the dummy > >>> codec to McBSP !3 and use that, it would work in a same way, or to DMIC > >>> or McPDM... > >>> > >>> The McBSP ops are NULL for the dummy dai, so McBSP is turned off. > >> > >> Hmm yeah I don't know if the cpcap codec on the same mcbsp needs > >> mcbsp for voice call. > >> > >> According to Sebastian sounds like mcbsp can be idle at that point. > >> > >> But what about capture of voice call at the mcbsp from the > >> TDM slot? In that case mcbsp would be active. > > > > Looks like only initializing only one mcbsp3 instance here > > instead of two will produce an oops as below. > > > > I'm not sure how this is supposed to work for > > snd-soc-audio-graph-card with multipe endpoints connected > > to just one mcbsp dai instance? > > > > Regards, > > > > Tony > > > > 8< ------------------- > What is the kernel version? > The context is missing... > Who printed the line: > dev_err(dev, "ASoC: Failed to register DAIs: %d\n", ret); Oh sorry, this was just a quick test with droid4-pending-v5.5 branch with only one mcbsp dai initialized. > This is only possible if snd_soc_component_initialize() fail, which can > only fail if snd_soc_component_unique_name() fails. > > > Internal error: Oops: 805 [#1] PREEMPT SMP ARM > > snd_soc_del_component_unlocked+0xf4/0x110 > > Not too helpful ;) Yeah I have not looked at it closer so far.. Regards, Tony > > ... > > [ 39.616027] Backtrace: > > [ 39.616149] [] (snd_soc_del_component_unlocked [snd_soc_core]) from [] (snd_soc_add_component+0x238/0x374 [snd_s) > > [ 39.616149] r7:00000002 r6:00000002 r5:ec9a0e78 r4:00000122 > > [ 39.678283] qmi_wwan 1-1:1.6: cdc-wdm1: USB WDM device > > [ 39.739074] [] (snd_soc_add_component [snd_soc_core]) from [] (snd_soc_register_component+0x50/0x60 [snd_soc_cor) > > [ 39.739074] r10:bf4582d0 r9:ec9d0840 r8:00000002 r7:00000002 r6:ec9d0640 r5:bf4584ac > > [ 39.800842] asoc-audio-graph-card soundcard: using device tree for GPIO lookup > > [ 39.808685] r4:eed52410 > > [ 39.862304] [] (snd_soc_register_component [snd_soc_core]) from [] (devm_snd_soc_register_component+0x54/0x90 [s) > > [ 39.862304] r7:ec9d0640 r6:bf4584ac r5:ec9d3040 r4:eed52410 > > [ 39.925048] qmi_wwan 1-1:1.6 wwan1: register 'qmi_wwan' at usb-4a064800.ohci-1, WWAN/QMI device, 2e:59:df:3f:4f:ef > > [ 39.984558] [] (devm_snd_soc_register_component [snd_soc_core]) from [] (asoc_mcbsp_probe+0x3e8/0x574 [snd_soc_o) > > [ 39.984558] r9:ec9d0840 r8:ec9f4000 r7:eed52410 r6:00000000 r5:eed52400 r4:ec9d0840 > > [ 39.984588] [] (asoc_mcbsp_probe [snd_soc_omap_mcbsp]) from [] (platform_drv_probe+0x58/0xa8) > > [ 39.984619] r10:00000000 r9:0000002e r8:bf459014 r7:00000000 r6:bf459014 r5:00000000 > > [ 40.044342] of_get_named_gpiod_flags: can't parse 'pa-gpios' property of node '/soundcard[0]' > > [ 40.051788] r4:eed52410 > > [ 40.100769] [] (platform_drv_probe) from [] (really_probe+0x1ec/0x358) > > > > - Péter > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki