From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A38E4C34047 for ; Tue, 18 Feb 2020 15:51:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B0B7207FD for ; Tue, 18 Feb 2020 15:51:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726582AbgBRPvv (ORCPT ); Tue, 18 Feb 2020 10:51:51 -0500 Received: from mga09.intel.com ([134.134.136.24]:47243 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726338AbgBRPvv (ORCPT ); Tue, 18 Feb 2020 10:51:51 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Feb 2020 07:51:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,456,1574150400"; d="scan'208";a="382490238" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004.jf.intel.com with ESMTP; 18 Feb 2020 07:51:46 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1j45A4-0035xT-CI; Tue, 18 Feb 2020 17:51:48 +0200 Date: Tue, 18 Feb 2020 17:51:48 +0200 From: Andy Shevchenko To: Fabien Parent Cc: "fengping.yu" , Dmitry Torokhov , Rob Herring , Marco Felsch , Matthias Brugger , DTML , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V3 2/2] drivers: input: keyboard: add mtk keypad driver Message-ID: <20200218155148.GJ10400@smile.fi.intel.com> References: <20200114122738.103344-1-fengping.yu@mediatek.com> <20200114122738.103344-3-fengping.yu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 18, 2020 at 04:14:24PM +0100, Fabien Parent wrote: > On Tue, Jan 14, 2020 at 1:39 PM fengping.yu wrote: ... > > +#define KP_STA 0x0000 > > +#define KP_MEM1 0x0004 > > +#define KP_MEM2 0x0008 > > +#define KP_MEM3 0x000c > > +#define KP_MEM4 0x0010 > > +#define KP_MEM5 0x0014 > > +#define KP_DEBOUNCE 0x0018 > > +#define KP_SEL 0x0020 > > +#define KP_EN 0x0024 ... > > +#define KPD_NUM_MEMS 5 > > +#define KPD_MEM5_BITS 8 > > +#define KPD_NUM_KEYS 72 /* 4 * 16 + KPD_MEM5_BITS */ > > + kpd_get_keymap_state(keypad->base, new_state); > > kpd_get_keymap_state(keypad->base + KP_MEM1, new_state); Why? -- With Best Regards, Andy Shevchenko