* [PATCH] bridge: br_stp: Use built-in RCU list checking
@ 2020-02-19 15:17 madhuparnabhowmik10
2020-02-19 19:14 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: madhuparnabhowmik10 @ 2020-02-19 15:17 UTC (permalink / raw)
To: roopa, nikolay, davem
Cc: bridge, netdev, linux-kernel, joel, frextrite,
linux-kernel-mentees, paulmck, Madhuparna Bhowmik
From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
list_for_each_entry_rcu() has built-in RCU and lock checking.
Pass cond argument to list_for_each_entry_rcu() to silence
false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
by default.
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
---
net/bridge/br_stp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c
index 1f1410f8d312..8be12452071b 100644
--- a/net/bridge/br_stp.c
+++ b/net/bridge/br_stp.c
@@ -52,7 +52,8 @@ struct net_bridge_port *br_get_port(struct net_bridge *br, u16 port_no)
{
struct net_bridge_port *p;
- list_for_each_entry_rcu(p, &br->port_list, list) {
+ list_for_each_entry_rcu(p, &br->port_list, list,
+ lockdep_is_held(&br->lock)) {
if (p->port_no == port_no)
return p;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bridge: br_stp: Use built-in RCU list checking
2020-02-19 15:17 [PATCH] bridge: br_stp: Use built-in RCU list checking madhuparnabhowmik10
@ 2020-02-19 19:14 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-02-19 19:14 UTC (permalink / raw)
To: madhuparnabhowmik10
Cc: roopa, nikolay, bridge, netdev, linux-kernel, joel, frextrite,
linux-kernel-mentees, paulmck
From: madhuparnabhowmik10@gmail.com
Date: Wed, 19 Feb 2020 20:47:46 +0530
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
> list_for_each_entry_rcu() has built-in RCU and lock checking.
>
> Pass cond argument to list_for_each_entry_rcu() to silence
> false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
> by default.
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-19 19:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-19 15:17 [PATCH] bridge: br_stp: Use built-in RCU list checking madhuparnabhowmik10
2020-02-19 19:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).