From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C7CCC34047 for ; Wed, 19 Feb 2020 17:36:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D2502464E for ; Wed, 19 Feb 2020 17:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582133782; bh=n68rtlOq2g52DbrL2K50i3HYY6NSis5K+k5x/xmKyr8=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:List-ID: From; b=ru/4c95j6NaeDqUM/stw7THgdyQwMDx/oJYpxXvXMxoCgY6EWVqMZofyUSjHMaTv+ ucnspyKXwD9rAtWltEwoebChaQN7nOlVACDd08GoHeCjLzL+6ETJIxFVOIHNxP71xM YT8Ld+y4VPaw6dHNfpO0PNbBMDaMJ8Uj8AcmSVcc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726779AbgBSRgV (ORCPT ); Wed, 19 Feb 2020 12:36:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:46558 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726518AbgBSRgV (ORCPT ); Wed, 19 Feb 2020 12:36:21 -0500 Received: from paulmck-ThinkPad-P72.home (50-39-105-78.bvtn.or.frontiernet.net [50.39.105.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3414B20801; Wed, 19 Feb 2020 17:36:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582133780; bh=n68rtlOq2g52DbrL2K50i3HYY6NSis5K+k5x/xmKyr8=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=wwi9imsdBeViLGikErNgnhaGf9071VFOCDpBO2oo7n/erM3qyHW4UTnylzqbukwxJ /tjQxrc2JzyHjfY5v6ukCzyHBKUPd3IpD7VPs8yMpyG14OqTIBQmtwFjXELKA1Z3aA eaT3rsnCNEyu+NyVtYGIP/tJ9baj8yaRLEJ3HcNE= Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 1123035209B0; Wed, 19 Feb 2020 09:36:20 -0800 (PST) Date: Wed, 19 Feb 2020 09:36:20 -0800 From: "Paul E. McKenney" To: Peter Zijlstra Cc: Steven Rostedt , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, mingo@kernel.org, joel@joelfernandes.org, gregkh@linuxfoundation.org, gustavo@embeddedor.com, tglx@linutronix.de, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, luto@kernel.org, tony.luck@intel.com, frederic@kernel.org, dan.carpenter@oracle.com, mhiramat@kernel.org, Marco Elver , Mark Rutland Subject: Re: [PATCH v3 16/22] locking/atomics, kcsan: Add KCSAN instrumentation Message-ID: <20200219173620.GI2935@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20200219144724.800607165@infradead.org> <20200219150745.299217979@infradead.org> <20200219104626.633f0650@gandalf.local.home> <20200219160318.GG18400@hirez.programming.kicks-ass.net> <20200219165020.GF2935@paulmck-ThinkPad-P72> <20200219165455.GM18400@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200219165455.GM18400@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 19, 2020 at 05:54:55PM +0100, Peter Zijlstra wrote: > On Wed, Feb 19, 2020 at 08:50:20AM -0800, Paul E. McKenney wrote: > > On Wed, Feb 19, 2020 at 05:03:18PM +0100, Peter Zijlstra wrote: > > > On Wed, Feb 19, 2020 at 10:46:26AM -0500, Steven Rostedt wrote: > > > > On Wed, 19 Feb 2020 15:47:40 +0100 > > > > Peter Zijlstra wrote: > > > > > > > > > From: Marco Elver > > > > > > > > > > This adds KCSAN instrumentation to atomic-instrumented.h. > > > > > > > > > > Signed-off-by: Marco Elver > > > > > Signed-off-by: Paul E. McKenney > > > > > [peterz: removed the actual kcsan hooks] > > > > > Signed-off-by: Peter Zijlstra (Intel) > > > > > Reviewed-by: Mark Rutland > > > > > --- > > > > > include/asm-generic/atomic-instrumented.h | 390 +++++++++++++++--------------- > > > > > scripts/atomic/gen-atomic-instrumented.sh | 14 - > > > > > 2 files changed, 212 insertions(+), 192 deletions(-) > > > > > > > > > > > > > > > > > Does this and the rest of the series depend on the previous patches in > > > > the series? Or can this be a series on to itself (patches 16-22)? > > > > > > It can probably stand on its own, but it very much is related in so far > > > that it's fallout from staring at all this nonsense. > > > > > > Without these the do_int3() can actually have accidental tracing before > > > reaching it's nmi_enter(). > > > > The original is already in -tip, so some merge magic will be required. > > Yes, So I don't strictly need this one, but I do need the two next > patches adding __always_inline to everything. I figured it was easier to > also pick this one (and butcher it) than to rebase everything. > > I didn't want to depend on the locking/kcsan tree, and if this goes in, > we do have to do something 'funny' there. Maybe rebase, maybe put in a > few kcsan stubs so the original patch at least compiles. We'll see :/ Fair enough! Thanx, Paul