archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <>
To: Sebastian Reichel <>
Cc: Peter Ujfalusi <>,
	Mark Brown <>,
	Liam Girdwood <>,
	Jaroslav Kysela <>, Takashi Iwai <>,,,, "Arthur D ." <>,
	Merlijn Wajer <>, Pavel Machek <>,
	Jarkko Nikula <>
Subject: Re: [PATCH] ASoC: cpcap: Implement set_tdm_slot for voice call support
Date: Wed, 19 Feb 2020 10:53:02 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20200218170628.r47xc3yydg6xx2yh@earth.universe>

* Sebastian Reichel <> [200218 17:07]:
> On Tue, Feb 18, 2020 at 07:32:11AM -0800, Tony Lindgren wrote:
> > OK, but so what's the machine driver part in this case?
> simple-graph-card is the current machine driver. We might have to
> introduce a Droid 4 specific driver instead. I used simple(-graph)-card
> instead of introducing a new driver, since the setup was simple enough
> without modem and bluetooth. The simple card was perfect to test the CPCAP
> codec driver. The TDM things might be complex enough to create
> a new machine driver (as I mentioned in the original patchset
> adding CPCAP codec support).

Well we do have the .set_tdm_slot to configure things. If it turns
out we only need to track the machine audio state in cpcap.c, then
we don't need a separate machine driver.

However, if it turns out that cpcap is not always active for
some audio paths, then yeah it seems that we need a custom
machine driver to keep track of the machine audio state.

> Note: Don't use Motorola's tree to learn about ASoC. Their soundcard
> and cpcap codec drivers are full of weird hacks. I'm pretty sure the
> author(s) did not really understand how ASoC works. From my
> experience you should only use their code to understand the
> hardware wiring. You might also want to look into the MC13783
> datasheet for the keyword "network mode".

Yeah nope. And just dumping out the cpcap registers in Android
seems to provide enough information to get the missing features



      parent reply	other threads:[~2020-02-19 18:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 18:10 Tony Lindgren
2020-02-12  9:17 ` Peter Ujfalusi
2020-02-12 14:46   ` Tony Lindgren
2020-02-14 13:29     ` Peter Ujfalusi
2020-02-17 23:23       ` Tony Lindgren
2020-02-18 15:15         ` Peter Ujfalusi
2020-02-18 15:32           ` Tony Lindgren
2020-02-18 16:44             ` Mark Brown
2020-02-18 17:06             ` Sebastian Reichel
2020-02-18 17:42               ` Mark Brown
2020-02-19 17:39                 ` Tony Lindgren
2020-02-19 17:46                   ` Mark Brown
2020-02-19 18:49                     ` Tony Lindgren
2020-02-19 18:53               ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] ASoC: cpcap: Implement set_tdm_slot for voice call support' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).