From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A353C761A1 for ; Thu, 20 Feb 2020 01:22:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E55172465D for ; Thu, 20 Feb 2020 01:22:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582161760; bh=CDpuM9GYEvWuxtuOP+rfr6nBLZ0AwQBJjH4hsetxWwg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=La6GHi5Gf4Be/T1OpgFZU/BScXJ2HKudj9Iy/I+coBnvKyXp+sNViAAi0chit1LGQ e2KY6PebTtSCMMxMMcJWq15SMCE7KhRbLPkJb/W1TKrXIUlsE33guA9knilRSgv9Xu A33wM+CF4b+UDomOZkWnRrsna7JnkQG1/iqio/TE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727578AbgBTBWi (ORCPT ); Wed, 19 Feb 2020 20:22:38 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:43379 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726784AbgBTBWi (ORCPT ); Wed, 19 Feb 2020 20:22:38 -0500 Received: by mail-pf1-f193.google.com with SMTP id s1so1023704pfh.10; Wed, 19 Feb 2020 17:22:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=e66XU0nEoA5qfNXWLeMAQwu6IxKmeV1IChHBVZH9fZk=; b=c1yKwx8m+HVIJQboFbLSAZ+3HAg48GUgwXTmg/LWG7ELX0lDLLCvGkwn6LVGlifdXN TWK8Ula3By43vN3PPJdr3vFJqRzEDSlUjryKFNy7jr3yGnRdvTg8heh7TF/4Rq02UxDo Livy3q0dLF2du9O+K0vXzdHeEdmhw2uxjxf/wZoopgBG6+Fp2GdZTBGi4hOq6UqN6byp RLv2oCW4CGz0LXGauQfyttEbRFQl0ft4dHL4FWGOybIiAT7uU6PZXim3lzT1ifMbfW8I DDZZ12kPPJOowb2xCMPmWbkzHz+toSWk0b72wpzhpJIsJ4GQziz3b6PukyBXx3JNEf+/ fCMQ== X-Gm-Message-State: APjAAAViAscJn8RdCbuJHLwHF4UxXDh1oRbotyM43/EKGoZQ1AzLZWhC IQQijCkm9vCXgry33JQ0Srw= X-Google-Smtp-Source: APXvYqw3dWDdJVdt4sc0Bvx5FVv68mBP8ks6VkDsDXnz/suX59U3WQKFkGJYnaRq222Z5IyP3TMQ2A== X-Received: by 2002:aa7:8101:: with SMTP id b1mr29983093pfi.105.1582161757397; Wed, 19 Feb 2020 17:22:37 -0800 (PST) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id t8sm944926pjy.20.2020.02.19.17.22.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2020 17:22:36 -0800 (PST) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id A678F402D7; Thu, 20 Feb 2020 01:22:35 +0000 (UTC) Date: Thu, 20 Feb 2020 01:22:35 +0000 From: Luis Chamberlain To: Scott Branden Cc: Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , bjorn.andersson@linaro.org, Shuah Khan , Arnd Bergmann , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson , Andrew Morton , Dan Carpenter , Colin Ian King , Kees Cook , Takashi Iwai , linux-kselftest@vger.kernel.org, Andy Gross Subject: Re: [PATCH v2 2/7] firmware: add offset to request_firmware_into_buf Message-ID: <20200220012235.GU11244@42.do-not-panic.com> References: <20200220004825.23372-1-scott.branden@broadcom.com> <20200220004825.23372-3-scott.branden@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200220004825.23372-3-scott.branden@broadcom.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 19, 2020 at 04:48:20PM -0800, Scott Branden wrote: > Add offset to request_firmware_into_buf to allow for portions > of firmware file to be read into a buffer. Necessary where firmware > needs to be loaded in portions from file in memory constrained systems. > > Signed-off-by: Scott Branden Thanks for following up Scott! However you failed to address the feedback last time by Takashi, so until then, this remains a blocker for this. http://lkml.kernel.org/r/s5hwoeyj3i5.wl-tiwai@suse.de Luis