From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Ripard <maxime@cerno.tech>, Chen-Yu Tsai <wens@csie.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Icenowy Zheng <icenowy@aosc.io>, Torsten Duwe <duwe@suse.de>,
Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
Linus Walleij <linus.walleij@linaro.org>,
Stephan Gerhold <stephan@gerhold.net>,
Mark Brown <broonie@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Samuel Holland <samuel@sholland.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Vasily Khoruzhick <anarsoul@gmail.com>
Subject: [PATCH 2/6] drm/bridge: anx6345: Clean up error handling in probe()
Date: Thu, 20 Feb 2020 00:35:04 -0800 [thread overview]
Message-ID: <20200220083508.792071-3-anarsoul@gmail.com> (raw)
In-Reply-To: <20200220083508.792071-1-anarsoul@gmail.com>
devm_regulator_get() returns either a dummy regulator or -EPROBE_DEFER,
we don't need to print scary message in either case.
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
index 0d8d083b0207..0204bbe4f0a0 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
@@ -713,17 +713,13 @@ static int anx6345_i2c_probe(struct i2c_client *client,
/* 1.2V digital core power regulator */
anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12");
- if (IS_ERR(anx6345->dvdd12)) {
- DRM_ERROR("dvdd12-supply not found\n");
+ if (IS_ERR(anx6345->dvdd12))
return PTR_ERR(anx6345->dvdd12);
- }
/* 2.5V digital core power regulator */
anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25");
- if (IS_ERR(anx6345->dvdd25)) {
- DRM_ERROR("dvdd25-supply not found\n");
+ if (IS_ERR(anx6345->dvdd25))
return PTR_ERR(anx6345->dvdd25);
- }
/* GPIO for chip reset */
anx6345->gpiod_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
--
2.25.0
next prev parent reply other threads:[~2020-02-20 8:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 8:35 [PATCH 0/6] Add LCD support for Pine64 Pinebook 1080p Vasily Khoruzhick
2020-02-20 8:35 ` [PATCH 1/6] drm/bridge: anx6345: Fix getting anx6345 regulators Vasily Khoruzhick
2020-02-20 13:46 ` Laurent Pinchart
2020-02-21 8:32 ` Neil Armstrong
2020-02-21 11:05 ` Torsten Duwe
2020-02-20 8:35 ` Vasily Khoruzhick [this message]
2020-02-20 13:52 ` [PATCH 2/6] drm/bridge: anx6345: Clean up error handling in probe() Laurent Pinchart
2020-02-20 21:37 ` Vasily Khoruzhick
2020-02-20 8:35 ` [PATCH 3/6] dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor prefix Vasily Khoruzhick
2020-02-20 9:35 ` Sam Ravnborg
2020-02-20 21:37 ` Vasily Khoruzhick
2020-02-20 13:56 ` Laurent Pinchart
2020-02-20 21:21 ` Sam Ravnborg
2020-02-20 21:36 ` Vasily Khoruzhick
2020-02-20 21:37 ` Vasily Khoruzhick
2020-02-20 8:35 ` [PATCH 4/6] dt-bindings: display: simple: Add NewEast Optoelectronics WJFH116008A compatible Vasily Khoruzhick
2020-02-20 13:54 ` Laurent Pinchart
2020-02-20 8:35 ` [PATCH 5/6] drm/panel: simple: Add NewEast Optoelectronics CO., LTD WJFH116008A panel support Vasily Khoruzhick
2020-02-20 13:59 ` Laurent Pinchart
2020-02-20 21:37 ` Vasily Khoruzhick
2020-02-20 8:35 ` [PATCH 6/6] arm64: allwinner: a64: enable LCD-related hardware for Pinebook Vasily Khoruzhick
2020-02-20 14:17 ` Laurent Pinchart
2020-02-20 21:37 ` Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220083508.792071-3-anarsoul@gmail.com \
--to=anarsoul@gmail.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=duwe@suse.de \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime@cerno.tech \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=samuel@sholland.org \
--cc=sfr@canb.auug.org.au \
--cc=stephan@gerhold.net \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).