From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A175AC11D04 for ; Thu, 20 Feb 2020 11:11:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D8BA2465D for ; Thu, 20 Feb 2020 11:11:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582197092; bh=IqGe6nRCCTQfy3YAt4b2Q5IEeKFTp0zXzs+XkdE28gI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KgIbhTjSCedzjm6yWTxrJB1u2iKUQDsCIVTojaPq75nnEsnsXlcGBdIS07urgART9 FNIWw4OTPowmItKxk2MtJRWsJLlYIO1W/yIgdNmKK4W0SC6pFoH2sMsyEhQV5BtREh MqezLiNOXyrgkzTn+6lrIQKiFRLfysVqiBPe85pw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727910AbgBTLLb (ORCPT ); Thu, 20 Feb 2020 06:11:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:49422 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726825AbgBTLLa (ORCPT ); Thu, 20 Feb 2020 06:11:30 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C46B7207FD; Thu, 20 Feb 2020 11:11:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582197090; bh=IqGe6nRCCTQfy3YAt4b2Q5IEeKFTp0zXzs+XkdE28gI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WyJ//zoefTT+rMGmjkFcz4gvqZoLverrcxN7cUa5pnwP2WCbsH8OxHm/+ugHLMugp 36IqGmoz1MYF1GebhMGHoDu0kzfVMzhf3e3fPajymIeMteurj9DOpEaR1bUIPyys0n 5ESZa+XJFlbvgM1WYaWfz1+60l9Q8sdYJWTVkRLo= Date: Thu, 20 Feb 2020 12:11:28 +0100 From: Greg Kroah-Hartman To: Christian Brauner Cc: "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "Rafael J. Wysocki" , Pavel Machek , Jakub Kicinski , Eric Dumazet , Stephen Hemminger , linux-pm@vger.kernel.org Subject: Re: [PATCH net-next v3 1/9] sysfs: add sysfs_file_change_owner{_by_name}() Message-ID: <20200220111128.GC3374196@kroah.com> References: <20200218162943.2488012-1-christian.brauner@ubuntu.com> <20200218162943.2488012-2-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200218162943.2488012-2-christian.brauner@ubuntu.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 18, 2020 at 05:29:35PM +0100, Christian Brauner wrote: > Add helpers to change the owner of a sysfs files. > This function will be used to correctly account for kobject ownership > changes, e.g. when moving network devices between network namespaces. > > Signed-off-by: Christian Brauner > --- > /* v2 */ > - Greg Kroah-Hartman : > - Better naming for sysfs_file_change_owner() to reflect the fact that it > can be used to change the owner of the kobject itself by passing NULL as > argument. > - Christian Brauner : > - Split sysfs_file_change_owner() into two helpers sysfs_change_owner() and > sysfs_change_owner_by_name(). The former changes the owner of the kobject > itself, the latter the owner of the kobject looked up via the name > argument. > > /* v3 */ > - Greg Kroah-Hartman : > - Add explicit uid/gid parameters. Looks much better, thanks for doing these changes. I'll review the whole series now... greg k-h