From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44363C35640 for ; Fri, 21 Feb 2020 08:17:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D03A2468A for ; Fri, 21 Feb 2020 08:17:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582273041; bh=FTOGElWgnVJw8gJktUCYPCksvhO+Fz5drW+cZvE/jw0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LndgNQ0vofRHXjM5gP8FjiYIAmOk+6qhYsPe1nLk5inwoEcRleU4yz4E9yMNwh+dL 8Vop+mweAsKYQp2vY/Cn2jIe8B5Qy+c+7+/yPLzyd+EId/6zf6VKoYKJmEBVg98WBL GA/ZWi4l8GXIKzlU+rYTRfQVlQFTBlF7849tnluA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387656AbgBUIRT (ORCPT ); Fri, 21 Feb 2020 03:17:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:54644 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387632AbgBUIRQ (ORCPT ); Fri, 21 Feb 2020 03:17:16 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A30D124670; Fri, 21 Feb 2020 08:17:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582273035; bh=FTOGElWgnVJw8gJktUCYPCksvhO+Fz5drW+cZvE/jw0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NbamVl0PR69AH7j273RKpn38Clcu2KXJDRw6T+/PwBuNKHg8KPPyUlBlptkhGP9ay qKrLhy5ZxW5Idx2XJieLm68gfsut+VZM0XHMxFmYiYqaXuXvoQ0B8mXvfRw0WjxLWa uDfuh5hsKKfr9oetNLXr0IwyUN8WBol7raZ0As0k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Auger , Jacob Pan , Lu Baolu , Joerg Roedel , Sasha Levin Subject: [PATCH 4.19 024/191] iommu/vt-d: Fix off-by-one in PASID allocation Date: Fri, 21 Feb 2020 08:39:57 +0100 Message-Id: <20200221072254.091418459@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200221072250.732482588@linuxfoundation.org> References: <20200221072250.732482588@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jacob Pan [ Upstream commit 39d630e332144028f56abba83d94291978e72df1 ] PASID allocator uses IDR which is exclusive for the end of the allocation range. There is no need to decrement pasid_max. Fixes: af39507305fb ("iommu/vt-d: Apply global PASID in SVA") Reported-by: Eric Auger Signed-off-by: Jacob Pan Reviewed-by: Eric Auger Signed-off-by: Lu Baolu Signed-off-by: Joerg Roedel Signed-off-by: Sasha Levin --- drivers/iommu/intel-svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c index fd8730b2cd46e..5944d3b4dca37 100644 --- a/drivers/iommu/intel-svm.c +++ b/drivers/iommu/intel-svm.c @@ -377,7 +377,7 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_ /* Do not use PASID 0 in caching mode (virtualised IOMMU) */ ret = intel_pasid_alloc_id(svm, !!cap_caching_mode(iommu->cap), - pasid_max - 1, GFP_KERNEL); + pasid_max, GFP_KERNEL); if (ret < 0) { kfree(svm); kfree(sdev); -- 2.20.1