From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22F4CC35641 for ; Fri, 21 Feb 2020 08:38:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E625820722 for ; Fri, 21 Feb 2020 08:38:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582274322; bh=ADrNRk9Xu2Bg/SkJkQl9rV35sOxTlaMCztQvFTIMKlw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ovrayMeIQlOUrzZa1rxCLv9gxf1TF9JUPHfE9rMGdXAM4XpTPw5tUXVL62LnsrDaP KahYCQuxc/VkxJpybRZ3CsrcfG2vyI6PNhWbPKK7+NXsQ4xI+FiVKhFudtgF1l/ifG ddcoUtJqVoXejXEXbuCRopWUENxRcVdlcpYnNjtk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731360AbgBUIC3 (ORCPT ); Fri, 21 Feb 2020 03:02:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:34906 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731353AbgBUICZ (ORCPT ); Fri, 21 Feb 2020 03:02:25 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E28E8222C4; Fri, 21 Feb 2020 08:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582272145; bh=ADrNRk9Xu2Bg/SkJkQl9rV35sOxTlaMCztQvFTIMKlw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wIQL2znBts8xrR/MhTo3OT83KqwXiEDrfmGAeTiNjwcadrmAdVqAGTo0jInAJ3djf qynh/1jIJ8lKz0d4Lp9l9Fzd+/1bPanDIzYFqSlE0qom2VDgeOpatXbpHunZK4KvJA Vj/ko2DOWTTa54Kkve9R/Q1XiXpQDSEoNy9hvv0M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Davide Caratti , Jiri Pirko , "David S. Miller" Subject: [PATCH 5.4 006/344] net/sched: flower: add missing validation of TCA_FLOWER_FLAGS Date: Fri, 21 Feb 2020 08:36:45 +0100 Message-Id: <20200221072349.866786649@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200221072349.335551332@linuxfoundation.org> References: <20200221072349.335551332@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Davide Caratti [ Upstream commit e2debf0852c4d66ba1a8bde12869b196094c70a7 ] unlike other classifiers that can be offloaded (i.e. users can set flags like 'skip_hw' and 'skip_sw'), 'cls_flower' doesn't validate the size of netlink attribute 'TCA_FLOWER_FLAGS' provided by user: add a proper entry to fl_policy. Fixes: 5b33f48842fa ("net/flower: Introduce hardware offload support") Signed-off-by: Davide Caratti Acked-by: Jiri Pirko Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/sched/cls_flower.c | 1 + 1 file changed, 1 insertion(+) --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -689,6 +689,7 @@ static const struct nla_policy fl_policy .len = 128 / BITS_PER_BYTE }, [TCA_FLOWER_KEY_CT_LABELS_MASK] = { .type = NLA_BINARY, .len = 128 / BITS_PER_BYTE }, + [TCA_FLOWER_FLAGS] = { .type = NLA_U32 }, }; static const struct nla_policy