From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39AB5C35641 for ; Fri, 21 Feb 2020 08:13:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0CB562467A for ; Fri, 21 Feb 2020 08:13:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582272824; bh=2spouiENZlNYp3MJcPrlIyDeaNk6twYapLciEAA6zdg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Bm/jwJGGr+NwGWhkpgbT85YGhLPAIL7y5qAjUG/oM3A60yDI0k/iRam4uGwUZikRm meOH1Oo3JtjjW77+ZQQvQNSFA19bystAIaKW7eCOYuywnsOIJUk+Jz1AEEj2OLFYDA PUB+uAgrh/Qo5NpHUn7HJ7NATOe3ikCdJbVsMEwY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733043AbgBUINm (ORCPT ); Fri, 21 Feb 2020 03:13:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:49884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733026AbgBUINk (ORCPT ); Fri, 21 Feb 2020 03:13:40 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F249524650; Fri, 21 Feb 2020 08:13:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582272820; bh=2spouiENZlNYp3MJcPrlIyDeaNk6twYapLciEAA6zdg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p26Hr/ts1N0s5nA4cJw7qorG4dHpDIUPy/1SFeCa9Pb9puCJQDNqXRvkIQ9NZl33M r1tWHsavISLgJy9vMcdIZZ6vKhlrZv6ucKHgKly0NjCT54CJTIwCJlpi6opOjDYJgI K83sc6x3FHxFfMw4YCe9Bzp+Xf2KQJEBcpGeQUKo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liang Chen , Christoph Hellwig , Coly Li , Jens Axboe , Sasha Levin Subject: [PATCH 5.4 287/344] bcache: cached_dev_free needs to put the sb page Date: Fri, 21 Feb 2020 08:41:26 +0100 Message-Id: <20200221072415.873554828@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200221072349.335551332@linuxfoundation.org> References: <20200221072349.335551332@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liang Chen [ Upstream commit e8547d42095e58bee658f00fef8e33d2a185c927 ] Same as cache device, the buffer page needs to be put while freeing cached_dev. Otherwise a page would be leaked every time a cached_dev is stopped. Signed-off-by: Liang Chen Signed-off-by: Christoph Hellwig Signed-off-by: Coly Li Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/md/bcache/super.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 64999c7a8033f..b86cf72033401 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -1274,6 +1274,9 @@ static void cached_dev_free(struct closure *cl) mutex_unlock(&bch_register_lock); + if (dc->sb_bio.bi_inline_vecs[0].bv_page) + put_page(bio_first_page_all(&dc->sb_bio)); + if (!IS_ERR_OR_NULL(dc->bdev)) blkdev_put(dc->bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL); -- 2.20.1