From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DCCAC35641 for ; Fri, 21 Feb 2020 08:14:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA5B924650 for ; Fri, 21 Feb 2020 08:14:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582272862; bh=dfkQTTlWdh9yeBtr6FQzHpZfrJDgKsq5R03253NZN1g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=kAUiymckyyZkLmkUhGEFVMC53H7P2BVkIqn2AdgIYIjCQNoVNppGWgEsxDj8/OSvc PhbFm00mwcc+vjhmPQGSlL2396KSuQQYnF9T//umyabcfhKyHb80WKwDLgtMmZxD63 T7SCT29ibNm+PGTesSQ43OzUayuxgsULbe8tSEcw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732621AbgBUIOU (ORCPT ); Fri, 21 Feb 2020 03:14:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:50734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732732AbgBUIOS (ORCPT ); Fri, 21 Feb 2020 03:14:18 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F84C2467A; Fri, 21 Feb 2020 08:14:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582272857; bh=dfkQTTlWdh9yeBtr6FQzHpZfrJDgKsq5R03253NZN1g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MOubqzmLX/DvNbIz8Kn5RjiNRbA4HUFausXZGlPa9u0Jhd/ny1VRPZLQTZTlmHfxF JCFrxX+1kvQ3sunmP5LHRzqSqmVzipTfsU8YRrz3uo0U9a/YQlT4gGS4hg6079wygj NLnxdJ45t+2KC44si8Qxl2a66W0IPD4i+5TrHcJw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , "Paulo Alcantara (SUSE)" , Steve French , Sasha Levin Subject: [PATCH 5.4 302/344] cifs: fix unitialized variable poential problem with network I/O cache lock patch Date: Fri, 21 Feb 2020 08:41:41 +0100 Message-Id: <20200221072417.330758319@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200221072349.335551332@linuxfoundation.org> References: <20200221072349.335551332@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steve French [ Upstream commit 463a7b457c02250a84faa1d23c52da9e3364aed2 ] static analysis with Coverity detected an issue with the following commit: Author: Paulo Alcantara (SUSE) Date: Wed Dec 4 17:38:03 2019 -0300 cifs: Avoid doing network I/O while holding cache lock Addresses-Coverity: ("Uninitialized pointer read") Reported-by: Colin Ian King Signed-off-by: Paulo Alcantara (SUSE) Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/cifs/dfs_cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c index 2faa05860a483..cf6cec59696c2 100644 --- a/fs/cifs/dfs_cache.c +++ b/fs/cifs/dfs_cache.c @@ -1319,7 +1319,7 @@ static struct cifs_ses *find_root_ses(struct dfs_cache_vol_info *vi, char *mdata = NULL, *devname = NULL; struct TCP_Server_Info *server; struct cifs_ses *ses; - struct smb_vol vol; + struct smb_vol vol = {NULL}; rpath = get_dfs_root(path); if (IS_ERR(rpath)) -- 2.20.1