From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D590C35646 for ; Fri, 21 Feb 2020 11:44:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6736624653 for ; Fri, 21 Feb 2020 11:44:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582285464; bh=dl1o7B3h6sZDgG4E/cGCuPVa3J6ZrDeJyBg6plK5/Jc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=o+DKF5LdHO1JNCUFsNesf2s1Da1JSMzFytx5heqwdD83GV+G5DOyh9Wi095nQi+oW 84WtO4+2z7r4ZHGbEky2M7uRkWjBap/fhmiv9jgv3Ew8gwDxcn7S98ENitfu9r8B0M WgxeKnL9MiJsNY59RT+KQ619nQEWGIwAw2Y3ftek= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727910AbgBULoX (ORCPT ); Fri, 21 Feb 2020 06:44:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:42976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727833AbgBULoV (ORCPT ); Fri, 21 Feb 2020 06:44:21 -0500 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1F8124670; Fri, 21 Feb 2020 11:44:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582285460; bh=dl1o7B3h6sZDgG4E/cGCuPVa3J6ZrDeJyBg6plK5/Jc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nj9FRQjuX09YKQ5NNMDxhsWmRXmikfLxfYHh88//rqOFt4Amj/dQtNkBCqdZwuMc7 xcKY1xN0TcazpjslxWJZ32gimTWi6Gkvms5eOU/ynNZ/pdECS+xiEYgrTRC5BWTUYD Nx/MC/gSXqJI/uf1mRK1+YIjipwLgTe8FXKFtaN8= From: Will Deacon To: linux-kernel@vger.kernel.org Cc: kernel-team@android.com, akpm@linux-foundation.org, Will Deacon , "K . Prasad" , Thomas Gleixner , Greg Kroah-Hartman , Frederic Weisbecker , Christoph Hellwig , Quentin Perret , Alexei Starovoitov , Masami Hiramatsu Subject: [PATCH 3/3] kallsyms: Unexport kallsyms_lookup_name() and kallsyms_on_each_symbol() Date: Fri, 21 Feb 2020 11:44:04 +0000 Message-Id: <20200221114404.14641-4-will@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200221114404.14641-1-will@kernel.org> References: <20200221114404.14641-1-will@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kallsyms_lookup_name() and kallsyms_on_each_symbol() are exported to modules despite having no in-tree users and being wide open to abuse by out-of-tree modules that can use them as a method to invoke arbitrary non-exported kernel functions. Unexport kallsyms_lookup_name() and kallsyms_on_each_symbol(). Cc: Alexei Starovoitov Cc: Masami Hiramatsu Cc: Thomas Gleixner Cc: Greg Kroah-Hartman Cc: Christoph Hellwig Cc: Quentin Perret Signed-off-by: Will Deacon --- kernel/kallsyms.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c index a9b3f660dee7..16c8c605f4b0 100644 --- a/kernel/kallsyms.c +++ b/kernel/kallsyms.c @@ -175,7 +175,6 @@ unsigned long kallsyms_lookup_name(const char *name) } return module_kallsyms_lookup_name(name); } -EXPORT_SYMBOL_GPL(kallsyms_lookup_name); int kallsyms_on_each_symbol(int (*fn)(void *, const char *, struct module *, unsigned long), @@ -194,7 +193,6 @@ int kallsyms_on_each_symbol(int (*fn)(void *, const char *, struct module *, } return module_kallsyms_on_each_symbol(fn, data); } -EXPORT_SYMBOL_GPL(kallsyms_on_each_symbol); static unsigned long get_symbol_pos(unsigned long addr, unsigned long *symbolsize, -- 2.25.0.265.gbab2e86ba0-goog