From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43ED6C35647 for ; Fri, 21 Feb 2020 11:53:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C471222C4 for ; Fri, 21 Feb 2020 11:53:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582285988; bh=IuAmYb7MC/2fejAZ6a0eR2/GE2OMz+gIiQ+fmN6YnIo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ytIGogXVvUnr20M/YsnhEABvsnQqJEhDpT357cb849EelCHw9tAzSb16silKrYwbU uacJIFlDeVmKn1ATLomM1+ipQ6NZXxPAMh+JlfHEIbT/fdZIrPmbpguqgPW34O7JMJ qUYx8mD0oL048QQxFrYqh4Xn/2/gpMdU/zHHlDNk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728011AbgBULxG (ORCPT ); Fri, 21 Feb 2020 06:53:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:46086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726909AbgBULxG (ORCPT ); Fri, 21 Feb 2020 06:53:06 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A0C15208C4; Fri, 21 Feb 2020 11:53:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582285986; bh=IuAmYb7MC/2fejAZ6a0eR2/GE2OMz+gIiQ+fmN6YnIo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iO05qof27ZPw7Jb/9oksMPMn27j2cOJ1/AohmaYwE03FpdDejMIXWZs1QL5eX/EgK RyrybzimBe8PYVqOUiOzpVqS0j8boQmVv912MUk36jhLmR1ufDXviyJluOiv03m6Vz QPPE/06V9gC/GBl/Qf+0fNGSWX1DfMv1umRXeMK0= Date: Fri, 21 Feb 2020 12:53:03 +0100 From: Greg Kroah-Hartman To: Will Deacon Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, akpm@linux-foundation.org, "K . Prasad" , Thomas Gleixner , Frederic Weisbecker , Christoph Hellwig , Quentin Perret , Alexei Starovoitov , Masami Hiramatsu Subject: Re: [PATCH 3/3] kallsyms: Unexport kallsyms_lookup_name() and kallsyms_on_each_symbol() Message-ID: <20200221115303.GB116368@kroah.com> References: <20200221114404.14641-1-will@kernel.org> <20200221114404.14641-4-will@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200221114404.14641-4-will@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 21, 2020 at 11:44:04AM +0000, Will Deacon wrote: > kallsyms_lookup_name() and kallsyms_on_each_symbol() are exported to > modules despite having no in-tree users and being wide open to abuse by > out-of-tree modules that can use them as a method to invoke arbitrary > non-exported kernel functions. > > Unexport kallsyms_lookup_name() and kallsyms_on_each_symbol(). > > Cc: Alexei Starovoitov > Cc: Masami Hiramatsu > Cc: Thomas Gleixner > Cc: Greg Kroah-Hartman > Cc: Christoph Hellwig > Cc: Quentin Perret > Signed-off-by: Will Deacon Reviewed-by: Greg Kroah-Hartman