From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97652C35659 for ; Fri, 21 Feb 2020 17:40:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68CB4222C4 for ; Fri, 21 Feb 2020 17:40:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S1zv+eyv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726701AbgBURkl (ORCPT ); Fri, 21 Feb 2020 12:40:41 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:34931 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725947AbgBURkk (ORCPT ); Fri, 21 Feb 2020 12:40:40 -0500 Received: by mail-wr1-f65.google.com with SMTP id w12so2973903wrt.2 for ; Fri, 21 Feb 2020 09:40:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=3V9d6h+w2Jn04j6QHprbTz1jBnUlayRXHk3bj59std0=; b=S1zv+eyvfvNLGritTRUO4O07zMDmH2GjJWPuiXIdVvT9rwyOC+uM4H0gOWvu+ZG7KC kOsSv3VIpoe9UPLxuvjnnDVkz4Dp8GU0MoTlYJlGUL5pWSc/rUBLrDMe/wAaNSM/BUnK Me8EM5xUyclfKueqfEGGeTUUgxgPkUZCr3eV4M0Gwi6DWnsPArzYVUKSuosGhHaIdJqm AFNgITQd7cNvZWvfkKidj38GQoZ5vIr+NFAT4ATDQWmJCWRnnxMv3Gxd8n8Al0+IZyQn oYDKiFRoJ3dxZzYmq1ebb22sbS69QYJAycY+JRDTaLK1YrfdlNMlMSNTqt0QUwsT3P+R 12QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=3V9d6h+w2Jn04j6QHprbTz1jBnUlayRXHk3bj59std0=; b=cfhsPgY2QN8o2cBiFW+DVoExSEJyHWv1bSrSm4PFlL4E7+5qHLDQYI82oWFp0k12OX 0wX7keXl5j9VVpCd8LPL1f7w/ux5eZl39T7WOhb4pT6v8rY8ToyWpV9Mx4iS9kCcFIp/ f0Iyo8IFhWvWOTZOrawGTRL7hKK0ChkJQ1HZGSoSx04miP4bCvD3iQ3x3DG0WBQet/TT bep9d2NKGBFWwYd4PGVMjmo0pPNS4eJmtlnZohSMkW1JFgxkkVv9YvncDJA4qOuTfIZu ySYaezlOAHg8biH/tZkJLpN9+Bmi4UBYF+gzIG/UHLtGXrKemJQnzILhK9oeKrTvPQ/T YWvA== X-Gm-Message-State: APjAAAUZc23sDZ46Xd4qYFL3WHMh0GiVul/wYvNTjC345J1vktqx5DBi S4AxTIolDUc4XewTzlNWzgrubQ== X-Google-Smtp-Source: APXvYqyMv9sqLAcg9X7RL2yIUHrWh1u/L1U9ff6yIGnRxUO9BHWyghYULmWGNzjMlwA/tOgJhZrSmA== X-Received: by 2002:adf:a19c:: with SMTP id u28mr49326009wru.221.1582306837974; Fri, 21 Feb 2020 09:40:37 -0800 (PST) Received: from linaro.org ([2a01:e34:ed2f:f020:903b:a048:f296:e3ae]) by smtp.gmail.com with ESMTPSA id f207sm4980688wme.9.2020.02.21.09.40.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Feb 2020 09:40:37 -0800 (PST) Date: Fri, 21 Feb 2020 18:40:33 +0100 From: Daniel Lezcano To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Peter De Schrijver , "Rafael J. Wysocki" , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Jasper Korten , David Heidelberg , Peter Geis , linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 05/17] ARM: tegra: Propagate error from tegra_idle_lp2_last() Message-ID: <20200221174033.GV10516@linaro.org> References: <20200212235134.12638-1-digetx@gmail.com> <20200212235134.12638-6-digetx@gmail.com> <20200221151612.GJ10516@linaro.org> <1a8c81ab-6f6a-8221-6a4e-c080ba595836@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1a8c81ab-6f6a-8221-6a4e-c080ba595836@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 21, 2020 at 08:21:41PM +0300, Dmitry Osipenko wrote: > 21.02.2020 18:16, Daniel Lezcano пишет: > > On Thu, Feb 13, 2020 at 02:51:22AM +0300, Dmitry Osipenko wrote: > >> Technically cpu_suspend() may fail and it's never good to lose information > >> about failure. For example things like cpuidle core could correctly sample > >> idling time in the case of failure. > >> > >> Acked-by: Peter De Schrijver > >> Tested-by: Peter Geis > >> Tested-by: Jasper Korten > >> Tested-by: David Heidelberg > >> Signed-off-by: Dmitry Osipenko > >> --- > > > > [ ... ] > > > >> cpu_cluster_pm_enter(); > >> suspend_cpu_complex(); > >> > >> - cpu_suspend(PHYS_OFFSET - PAGE_OFFSET, &tegra_sleep_cpu); > >> + err = cpu_suspend(PHYS_OFFSET - PAGE_OFFSET, &tegra_sleep_cpu); > >> > >> /* > >> * Resume L2 cache if it wasn't re-enabled early during resume, > >> @@ -208,6 +210,8 @@ void tegra_idle_lp2_last(void) > >> > >> restore_cpu_complex(); > > > > If the cpu_suspend fails, does restore_cpu_complex() need to be called ? > > Yes, because suspend_cpu_complex() didn't fail. I don't see any reason > why restore_cpu_complex() shouldn't be called, please clarify yours thought. If the suspend fails, the power down does not happen, thus the logic is not lost and then it not necessary to restore something which has not been lost. I don't know the hardware details, so that may be partially correct. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog