From: Masahiro Yamada <masahiroy@kernel.org>
To: linux-kbuild@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Rob Herring <robh@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/5] kbuild: fix DT binding schema rule to detect command line changes
Date: Sun, 23 Feb 2020 04:04:31 +0900 [thread overview]
Message-ID: <20200222190435.11767-1-masahiroy@kernel.org> (raw)
This if_change_rule is not working; it cannot detect any command line
changes.
The reason is because cmd-check in scripts/Kbuild.include compares
$(cmd_$@) and $(cmd_$1), but cmd_dtc_dt_yaml does not exist here.
For if_change_rule to work properly, the stem part of cmd_* and rule_*
must match. Because this cmd_and_fixdep invokes cmd_dtc, this rule must
be named rule_dtc.
Fixes: 4f0e3a57d6eb ("kbuild: Add support for DT binding schema checks")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
scripts/Makefile.lib | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index bae62549e3d2..64b938c10039 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -302,13 +302,13 @@ DT_TMP_SCHEMA := $(objtree)/$(DT_BINDING_DIR)/processed-schema.yaml
quiet_cmd_dtb_check = CHECK $@
cmd_dtb_check = $(DT_CHECKER) -u $(srctree)/$(DT_BINDING_DIR) -p $(DT_TMP_SCHEMA) $@ ;
-define rule_dtc_dt_yaml
+define rule_dtc
$(call cmd_and_fixdep,dtc,yaml)
$(call cmd,dtb_check)
endef
$(obj)/%.dt.yaml: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
- $(call if_changed_rule,dtc_dt_yaml)
+ $(call if_changed_rule,dtc)
dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp)
--
2.17.1
next reply other threads:[~2020-02-22 19:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-22 19:04 Masahiro Yamada [this message]
2020-02-22 19:04 ` [PATCH 2/5] kbuild: remove unneeded semicolon at the end of cmd_dtb_check Masahiro Yamada
2020-02-26 17:47 ` Masahiro Yamada
2020-02-22 19:04 ` [PATCH 3/5] kbuild: add dtbs_check to PHONY Masahiro Yamada
2020-02-26 17:47 ` Masahiro Yamada
2020-02-22 19:04 ` [PATCH 4/5] kbuild: add dt_binding_check to PHONY in a correct place Masahiro Yamada
2020-02-26 17:48 ` Masahiro Yamada
2020-02-22 19:04 ` [PATCH 5/5] kbuild: allow to run dt_binding_check and dtbs_check in a single command Masahiro Yamada
2020-02-26 6:46 ` Masahiro Yamada
2020-02-24 22:52 ` [PATCH 1/5] kbuild: fix DT binding schema rule to detect command line changes Rob Herring
2020-02-25 4:32 ` Masahiro Yamada
2020-02-26 17:47 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200222190435.11767-1-masahiroy@kernel.org \
--to=masahiroy@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).