From: Qais Yousef <firstname.lastname@example.org> To: Ingo Molnar <email@example.com>, Peter Zijlstra <firstname.lastname@example.org>, Steven Rostedt <email@example.com>, Dietmar Eggemann <firstname.lastname@example.org>, Pavan Kondeti <email@example.com> Cc: Juri Lelli <firstname.lastname@example.org>, Vincent Guittot <email@example.com>, Ben Segall <firstname.lastname@example.org>, Mel Gorman <email@example.com>, firstname.lastname@example.org, Qais Yousef <email@example.com> Subject: [PATCH v2 0/6] RT Capacity Awareness Fixes & Improvements Date: Sun, 23 Feb 2020 18:39:55 +0000 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) Pavan, Steve and Dietmar pointed out a few issues and improvements that could be done to the logic of RT Capacity Awareness. This series implements them. The main issue that triggered the discussion is the missing fallback mechanism in cpupri_find() if we are running on unfitting CPU and no fitting CPU was found. In this case we fallback to the best lowest_rq, which means unfitting tasks can move freely in unfitting CPUs, which better honours the priority of the task. This is implemented in patch 1. The 2nd major issue is on wakeup, the logic that forces a push was incomplete. Steve suggested using the overload flag, but Pavan pointed out this could cause unnecessary IPIs. Patch 5 addresses that. The discussion on patches 1-4 seemed to have reached a consensus. Patch 5 still needs more eyes staring at it. Pavan, if you can provide your Reviewed-by on the patches you're happy with that'd be appreciated. A Tested-by would be ever better :) Discussion on v1 can be found here: https://email@example.com/ Thanks Qais Yousef (6): sched/rt: cpupri_find: implement fallback mechanism for !fit case sched/rt: Re-instate old behavior in select_task_rq_rt sched/rt: Optimize cpupri_find on non-heterogenous systems sched/rt: allow pulling unfitting task sched/rt: Better manage pushing unfit tasks on wakeup sched/rt: Remove unnecessary assignment in inc/dec_rt_migration kernel/sched/cpupri.c | 167 +++++++++++++++++++++++++++--------------- kernel/sched/cpupri.h | 6 +- kernel/sched/rt.c | 137 ++++++++++++++++++++++++++++++---- kernel/sched/sched.h | 3 + 4 files changed, 237 insertions(+), 76 deletions(-) -- 2.17.1
next reply other threads:[~2020-02-23 18:40 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-23 18:39 Qais Yousef [this message] 2020-02-23 18:39 ` [PATCH v2 1/6] sched/rt: cpupri_find: implement fallback mechanism for !fit case Qais Yousef 2020-02-23 18:39 ` [PATCH v2 2/6] sched/rt: Re-instate old behavior in select_task_rq_rt Qais Yousef 2020-02-25 15:21 ` Dietmar Eggemann 2020-02-26 11:34 ` Qais Yousef 2020-02-23 18:39 ` [PATCH v2 3/6] sched/rt: Optimize cpupri_find on non-heterogenous systems Qais Yousef 2020-02-23 18:39 ` [PATCH v2 4/6] sched/rt: allow pulling unfitting task Qais Yousef 2020-02-23 18:40 ` [PATCH v2 5/6] sched/rt: Better manage pushing unfit tasks on wakeup Qais Yousef 2020-02-24 6:10 ` Pavan Kondeti 2020-02-24 12:11 ` Qais Yousef 2020-02-24 16:04 ` Pavan Kondeti 2020-02-24 17:41 ` Qais Yousef 2020-02-25 3:55 ` Pavan Kondeti 2020-02-26 16:02 ` Qais Yousef 2020-02-27 3:36 ` Pavan Kondeti 2020-02-27 10:29 ` Qais Yousef 2020-02-23 18:40 ` [PATCH v2 6/6] sched/rt: Remove unnecessary assignment in inc/dec_rt_migration Qais Yousef 2020-02-23 23:16 ` Dietmar Eggemann 2020-02-24 12:31 ` Qais Yousef 2020-02-24 13:03 ` Dietmar Eggemann 2020-02-24 13:47 ` Qais Yousef
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v2 0/6] RT Capacity Awareness Fixes & Improvements' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).