From: David Miller <davem@davemloft.net>
To: vicamo.yang@canonical.com
Cc: hayeswang@realtek.com, kuba@kernel.org, pmalani@chromium.org,
kai.heng.feng@canonical.com, grundler@chromium.org,
vicamo@gmail.com, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: r8151: check disconnect status after long sleep
Date: Mon, 24 Feb 2020 14:47:14 -0800 (PST) [thread overview]
Message-ID: <20200224.144714.329725174070305071.davem@davemloft.net> (raw)
In-Reply-To: <20200224071541.117363-1-vicamo.yang@canonical.com>
From: You-Sheng Yang <vicamo.yang@canonical.com>
Date: Mon, 24 Feb 2020 15:15:41 +0800
> When hotplugging such dock with additional usb devices already attached on
> it, the probing process may reset usb 2.1 port, therefore r8152 ethernet
> device is also reset. However, during r8152 device init there are several
> for-loops that, when it's unable to retrieve hardware registers due to
> being discconected from USB, may take up to 14 seconds each in practice,
> and that has to be completed before USB may re-enumerate devices on the
> bus. As a result, devices attached to the dock will only be available
> after nearly 1 minute after the dock was plugged in:
Your description of the problem and exactly what is happening is great,
but you are not explaining how exactly you are solving the problem and
why you are solving it in that way.
Please enhance your commit message the explain those things.
Thank you.
next prev parent reply other threads:[~2020-02-24 22:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 7:15 r8151: check disconnect status after long sleep You-Sheng Yang
2020-02-24 22:47 ` David Miller [this message]
2020-02-26 15:37 ` [PATCH v2] r8152: " You-Sheng Yang
2020-03-01 5:20 ` David Miller
2020-02-24 23:02 ` r8151: " Prashant Malani
2020-02-26 15:40 ` You-Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224.144714.329725174070305071.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=grundler@chromium.org \
--cc=hayeswang@realtek.com \
--cc=kai.heng.feng@canonical.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=vicamo.yang@canonical.com \
--cc=vicamo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).