From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michael Petlan <mpetlan@redhat.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
Andi Kleen <ak@linux.intel.com>, Kajol Jain <kjain@linux.ibm.com>,
John Garry <john.garry@huawei.com>
Subject: [PATCH 3/5] perf expr: Increase EXPR_MAX_OTHER
Date: Mon, 24 Feb 2020 09:29:16 +0100 [thread overview]
Message-ID: <20200224082918.58489-4-jolsa@kernel.org> (raw)
In-Reply-To: <20200224082918.58489-1-jolsa@kernel.org>
There's no need to be greedy on allowed variables, also
when some of the metrics define more than 15 variables,
like Branch_Misprediction_Cost.
Increasing the maximum to 100.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/util/expr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/expr.h b/tools/perf/util/expr.h
index 9332796e6649..01e1529bdfd9 100644
--- a/tools/perf/util/expr.h
+++ b/tools/perf/util/expr.h
@@ -2,7 +2,7 @@
#ifndef PARSE_CTX_H
#define PARSE_CTX_H 1
-#define EXPR_MAX_OTHER 15
+#define EXPR_MAX_OTHER 100
#define MAX_PARSE_ID EXPR_MAX_OTHER
struct parse_id {
--
2.24.1
next prev parent reply other threads:[~2020-02-24 8:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 8:29 [PATCHv2 0/5] perf expr: Add flex scanner Jiri Olsa
2020-02-24 8:29 ` [PATCH 1/5] perf expr: Add expr.c object Jiri Olsa
2020-02-24 8:29 ` [PATCH 2/5] perf expr: Move expr lexer to flex Jiri Olsa
2020-02-24 8:29 ` Jiri Olsa [this message]
2020-02-24 21:03 ` [PATCH 3/5] perf expr: Increase EXPR_MAX_OTHER Andi Kleen
2020-02-24 8:29 ` [PATCH 4/5] perf expr: Straighten expr__parse/expr__find_other interface Jiri Olsa
2020-02-24 8:29 ` [PATCH 5/5] perf expr: Make expr__parse return -1 on error Jiri Olsa
2020-02-27 12:10 ` [PATCHv2 0/5] perf expr: Add flex scanner Jiri Olsa
2020-02-27 13:46 ` Arnaldo Carvalho de Melo
2020-02-28 9:36 [PATCHv3 " Jiri Olsa
2020-02-28 9:36 ` [PATCH 3/5] perf expr: Increase EXPR_MAX_OTHER Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224082918.58489-4-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=john.garry@huawei.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=ravi.bangoria@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).