From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25260C35679 for ; Mon, 24 Feb 2020 08:50:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 01D312080D for ; Mon, 24 Feb 2020 08:50:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727189AbgBXIuA (ORCPT ); Mon, 24 Feb 2020 03:50:00 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:45023 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726216AbgBXIuA (ORCPT ); Mon, 24 Feb 2020 03:50:00 -0500 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j69R7-00066z-HS; Mon, 24 Feb 2020 09:49:57 +0100 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1j69R6-00064C-As; Mon, 24 Feb 2020 09:49:56 +0100 Date: Mon, 24 Feb 2020 09:49:56 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Lokesh Vutla Cc: Thierry Reding , Tony Lindgren , Linux OMAP Mailing List , linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Sekhar Nori Subject: Re: [PATCH 2/4] pwm: omap-dmtimer: Fix pwm enabling sequence Message-ID: <20200224084956.wwsnf2y24ragg3vf@pengutronix.de> References: <20200224052135.17278-1-lokeshvutla@ti.com> <20200224052135.17278-3-lokeshvutla@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200224052135.17278-3-lokeshvutla@ti.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 24, 2020 at 10:51:33AM +0530, Lokesh Vutla wrote: > To configure DM timer is pwm mode the following needs to be set in > OMAP_TIMER_CTRL_REG using set_pwm callback: > - Set toggle mode on PORTIMERPWM output pin > - Set trigger on overflow and match on PORTIMERPWM output pin. > - Set auto reload > > This is a one time configuration and needs to be set before the start of > the dm timer. But the current driver tries to set the same configuration > for every period/duty cycle update, which is not needed. So move the pwm > setup before enabling timer and do not update it in pwm_omap_dmtimer_config. Is this change kind of moot with the conversion to .apply in the next patch? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |