linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jerome Brunet <jbrunet@baylibre.com>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
	Kevin Hilman <khilman@baylibre.com>
Subject: [PATCH 1/9] ASoC: meson: gx-card: fix sound-dai dt schema
Date: Mon, 24 Feb 2020 15:58:13 +0100	[thread overview]
Message-ID: <20200224145821.262873-2-jbrunet@baylibre.com> (raw)
In-Reply-To: <20200224145821.262873-1-jbrunet@baylibre.com>

There is a fair amount of warnings when running 'make dtbs_check' with
amlogic,gx-sound-card.yaml.

Ex:
arch/arm64/boot/dts/amlogic/meson-gxm-q200.dt.yaml: sound: dai-link-0:sound-dai:0:1: missing phandle tag in 0
arch/arm64/boot/dts/amlogic/meson-gxm-q200.dt.yaml: sound: dai-link-0:sound-dai:0:2: missing phandle tag in 0
arch/arm64/boot/dts/amlogic/meson-gxm-q200.dt.yaml: sound: dai-link-0:sound-dai:0: [66, 0, 0] is too long

The reason is that the sound-dai phandle provided has cells, and in such
case the schema should use 'phandle-array' instead of 'phandle', even if
the property expects a single phandle.

Fixes: fd00366b8e41 ("ASoC: meson: gx: add sound card dt-binding documentation")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 Hi Mark,

 The statement above is based on this LKML discussion I found:
 https://lkml.org/lkml/2019/9/30/382

 To be honest, I don't really get why the consumer should know whether
 the phandle will have cells or not. AFAIK, the consumer does not care
 about this ...

 .../devicetree/bindings/sound/amlogic,gx-sound-card.yaml      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml b/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml
index fb374c659be1..a48222e8cd08 100644
--- a/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml
+++ b/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml
@@ -57,7 +57,7 @@ patternProperties:
           rate
 
       sound-dai:
-        $ref: /schemas/types.yaml#/definitions/phandle
+        $ref: /schemas/types.yaml#/definitions/phandle-array
         description: phandle of the CPU DAI
 
     patternProperties:
@@ -71,7 +71,7 @@ patternProperties:
 
         properties:
           sound-dai:
-            $ref: /schemas/types.yaml#/definitions/phandle
+            $ref: /schemas/types.yaml#/definitions/phandle-array
             description: phandle of the codec DAI
 
         required:
-- 
2.24.1


  reply	other threads:[~2020-02-24 14:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24 14:58 [PATCH 0/9] ASoC: meson: convert dt-bindings to schema Jerome Brunet
2020-02-24 14:58 ` Jerome Brunet [this message]
2020-02-28 15:48   ` [PATCH 1/9] ASoC: meson: gx-card: fix sound-dai dt schema Rob Herring
2020-02-24 14:58 ` [PATCH 2/9] ASoC: meson: convert axg tdm interface to schema Jerome Brunet
2020-02-28 15:50   ` Rob Herring
2020-02-28 16:57     ` Jerome Brunet
2020-02-28 17:16       ` Rob Herring
2020-02-24 14:58 ` [PATCH 3/9] ASoC: meson: convert axg tdm formatters " Jerome Brunet
2020-02-28 17:18   ` Rob Herring
2020-02-24 14:58 ` [PATCH 4/9] ASoC: meson: convert axg pdm " Jerome Brunet
2020-02-24 14:58 ` [PATCH 5/9] ASoC: meson: convert axg fifo " Jerome Brunet
2020-02-28 18:01   ` Rob Herring
2020-02-24 14:58 ` [PATCH 6/9] ASoC: meson: convert axg spdif input " Jerome Brunet
2020-02-24 14:58 ` [PATCH 7/9] ASoC: meson: convert axg spdif output " Jerome Brunet
2020-02-24 14:58 ` [PATCH 8/9] ASoC: meson: convert g12a tohdmitx control " Jerome Brunet
2020-02-24 14:58 ` [PATCH 9/9] ASoC: meson: convert axg sound card " Jerome Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200224145821.262873-2-jbrunet@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).