From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CED8C11D2F for ; Mon, 24 Feb 2020 16:33:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D18920CC7 for ; Mon, 24 Feb 2020 16:33:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582561998; bh=E4OC7Vt1SAJ3s4FEPYn8lscavIq6DIL8BmttAab8sCY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=z48n3ICcCvl+HXfaZ0AjYis2NmYDnhd/+21ICr/JqIfYn7nUnpW/bN/zmahuCSmT/ brbyRKkfErUSc6hPAUxJ1b7IHJQdhGlMgYsPp5hBYru/ZgmqO6b3zG6UBIdVidaE2K 2uoVTY6A6o2aUdUntPatvbUFHkF4u4EBZUrPHbX0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728085AbgBXQdR (ORCPT ); Mon, 24 Feb 2020 11:33:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:40574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727706AbgBXQdQ (ORCPT ); Mon, 24 Feb 2020 11:33:16 -0500 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7DB8F2080D; Mon, 24 Feb 2020 16:33:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582561996; bh=E4OC7Vt1SAJ3s4FEPYn8lscavIq6DIL8BmttAab8sCY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hLs946VYAUhcHFyxS2neXmgb8qjiUcglzrjWDjPh5Oz4PWe03gai85zvalXMBP8Uf LtNoLqJkpU6Udux1YQS8oTabkx9A5gnbqqtR5lHoDGS6+PLtUm27lVXW6w17Gml7a5 yCqJpVuHtCGPLkbz+32/3iIRCwB02nUKpCnRc6gE= Date: Mon, 24 Feb 2020 18:33:12 +0200 From: Leon Romanovsky To: Greg KH Cc: Geert Uytterhoeven , Linus Torvalds , David Miller , Doug Ledford , Ira Weiny , Andrew Morton , Network Development , Linux Kernel Mailing List Subject: Re: [GIT] Networking Message-ID: <20200224163312.GC4526@unreal> References: <20150624.063911.1220157256743743341.davem@davemloft.net> <20200224124732.GA694161@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200224124732.GA694161@kroah.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 24, 2020 at 01:47:32PM +0100, Greg KH wrote: > On Mon, Feb 24, 2020 at 11:01:09AM +0100, Geert Uytterhoeven wrote: > > Hi Linus, > > > > On Thu, Jun 25, 2015 at 1:38 AM Linus Torvalds > > wrote: > > > On Wed, Jun 24, 2015 at 6:39 AM, David Miller wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master > > > > > > On the *other* side of the same conflict, I find an even more > > > offensive commit, namely commit 4cd7c9479aff ("IB/mad: Add support for > > > additional MAD info to/from drivers") which adds a BUG_ON() for a > > > sanity check, rather than just returning -EINVAL or something sane > > > like that. > > > > > > I'm getting *real* tired of that BUG_ON() shit. I realize that > > > infiniband is a niche market, and those "commercial grade" niche > > > markets are more-than-used-to crap code and horrible hacks, but this > > > is still the kernel. We don't add random machine-killing debug checks > > > when it is *so* simple to just do > > > > > > if (WARN_ON_ONCE(..)) > > > return -EINVAL; > > > > > > instead. > > > > And if we follow that advice, friendly Greg will respond with: > > "We really do not want WARN_ON() anywhere, as that causes systems with > > panic-on-warn to reboot." > > https://lore.kernel.org/lkml/20191121135743.GA552517@kroah.com/ > > Yes, we should not have any WARN_ON calls for something that userspace > can trigger, because then syzbot will trigger it and we will get an > annoying report saying to fix it :) Impressive backlog :) Geert, you replied on original discussion from 2015. Thanks > > thanks, > > greg k-h