From: Kaaira Gupta <kgupta@es.iitr.ac.in>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Vaibhav Agarwal <vaibhav.sr@gmail.com>,
Mark Greer <mgreer@animalcreek.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [greybus-dev] [PATCH] staging: greybus: match parenthesis alignment
Date: Mon, 24 Feb 2020 22:23:44 +0530 [thread overview]
Message-ID: <20200224165344.GB7214@kaaira-HP-Pavilion-Notebook> (raw)
In-Reply-To: <20200224114929.GB4827@pendragon.ideasonboard.com>
On Mon, Feb 24, 2020 at 01:49:29PM +0200, Laurent Pinchart wrote:
> Hi Kaaira,
>
> Thank you for the patch.
>
> On Thu, Feb 20, 2020 at 01:26:51AM +0530, Kaaira Gupta wrote:
> > Fix checkpatch.pl warning of alignment should match open parenthesis in
> > audio_codec.c
> >
> > Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
> > ---
> > drivers/staging/greybus/audio_codec.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> > index 08746c85dea6..d62f91f4e9a2 100644
> > --- a/drivers/staging/greybus/audio_codec.c
> > +++ b/drivers/staging/greybus/audio_codec.c
> > @@ -70,7 +70,7 @@ static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec,
> > i2s_port = 0; /* fixed for now */
> > cportid = data->connection->hd_cport_id;
> > ret = gb_audio_apbridgea_register_cport(data->connection,
> > - i2s_port, cportid,
> > + i2s_port, cportid,
> > AUDIO_APBRIDGEA_DIRECTION_TX);
>
> I'm curious to know why you think the line you changed deserves a
> modification, while the next one doesn't :-)
According to me, both the lines deserve a modification. But I did not do
that as changing the other line was throwing 'greater than 80
characters' warning and I wasn't sure if I should go ahead with the
changes anyhow.
>
> > if (ret) {
> > dev_err_ratelimited(module->dev,
> > @@ -160,7 +160,7 @@ static int gbaudio_module_disable_tx(struct gbaudio_module_info *module, int id)
> > i2s_port = 0; /* fixed for now */
> > cportid = data->connection->hd_cport_id;
> > ret = gb_audio_apbridgea_unregister_cport(data->connection,
> > - i2s_port, cportid,
> > + i2s_port, cportid,
> > AUDIO_APBRIDGEA_DIRECTION_TX);
> > if (ret) {
> > dev_err_ratelimited(module->dev,
> > @@ -205,7 +205,7 @@ static int gbaudio_module_enable_rx(struct gbaudio_codec_info *codec,
> > i2s_port = 0; /* fixed for now */
> > cportid = data->connection->hd_cport_id;
> > ret = gb_audio_apbridgea_register_cport(data->connection,
> > - i2s_port, cportid,
> > + i2s_port, cportid,
> > AUDIO_APBRIDGEA_DIRECTION_RX);
> > if (ret) {
> > dev_err_ratelimited(module->dev,
> > @@ -295,7 +295,7 @@ static int gbaudio_module_disable_rx(struct gbaudio_module_info *module, int id)
> > i2s_port = 0; /* fixed for now */
> > cportid = data->connection->hd_cport_id;
> > ret = gb_audio_apbridgea_unregister_cport(data->connection,
> > - i2s_port, cportid,
> > + i2s_port, cportid,
> > AUDIO_APBRIDGEA_DIRECTION_RX);
> > if (ret) {
> > dev_err_ratelimited(module->dev,
>
> --
> Regards,
>
> Laurent Pinchart
prev parent reply other threads:[~2020-02-24 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 19:56 [PATCH] staging: greybus: match parenthesis alignment Kaaira Gupta
2020-02-19 20:19 ` Greg Kroah-Hartman
2020-02-24 11:49 ` [greybus-dev] " Laurent Pinchart
2020-02-24 16:53 ` Kaaira Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224165344.GB7214@kaaira-HP-Pavilion-Notebook \
--to=kgupta@es.iitr.ac.in \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).