From: hch <hch@infradead.org>
To: Nikolai Merinov <n.merinov@inango-systems.com>
Cc: hch <hch@infradead.org>, Davidlohr Bueso <dave@stgolabs.net>,
Jens Axboe <axboe@kernel.dk>, Ard Biesheuvel <ardb@kernel.org>,
linux-efi <linux-efi@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] partitions/efi: Fix partition name parsing in GUID partition entry
Date: Mon, 24 Feb 2020 09:08:13 -0800 [thread overview]
Message-ID: <20200224170813.GA27403@infradead.org> (raw)
In-Reply-To: <797777312.1324734.1582544319435.JavaMail.zimbra@inango-systems.com>
On Mon, Feb 24, 2020 at 01:38:39PM +0200, Nikolai Merinov wrote:
> Hi Christoph,
>
> > I'd rather use plain __le16 and le16_to_cpu here. Also the be
> > variants seems to be entirely unused.
>
> Looks like I misunderstood your comment from https://patchwork.kernel.org/patch/11309223/:
>
> > Please add a an efi_char_from_cpu or similarly named helper
> > to encapsulate this logic.
>
> The "le16_to_cpu(ptes[i].partition_name[label_count])" call is the
> full implementation of the "efi_char_from_cpu" logic. Do you want
> to encapsulate "utf16_le_to_7bit_string" logic entirely like in
> the attached version?
I think I though of just the inner loop, but your new version looks even
better, so:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-02-24 17:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 16:21 [PATCH] partitions/efi: Fix partition name parsing in GUID partition entry Nikolai Merinov
2018-11-25 21:16 ` kbuild test robot
2019-12-24 9:21 ` [PATCH v2] " Nikolai Merinov
2019-12-24 9:51 ` Ard Biesheuvel
2020-01-08 13:39 ` Christoph Hellwig
2020-01-13 10:27 ` [PATCH v3] " Nikolai Merinov
2020-02-18 13:34 ` Nikolai Merinov
2020-02-18 18:53 ` Christoph Hellwig
2020-02-24 11:38 ` Nikolai Merinov
2020-02-24 17:08 ` hch [this message]
2020-03-06 8:43 ` Nikolai Merinov
2020-03-06 9:25 ` Ard Biesheuvel
2020-03-06 10:14 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224170813.GA27403@infradead.org \
--to=hch@infradead.org \
--cc=ardb@kernel.org \
--cc=axboe@kernel.dk \
--cc=dave@stgolabs.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=n.merinov@inango-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).