From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
peter_hong@fintek.com.tw,
"Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V3 4/6] USB: serial: f81232: Add F81534A support
Date: Tue, 25 Feb 2020 12:13:32 +0100 [thread overview]
Message-ID: <20200225111332.GS32540@localhost> (raw)
In-Reply-To: <20200130054752.9368-5-hpeter+linux_kernel@gmail.com>
On Thu, Jan 30, 2020 at 01:47:50PM +0800, Ji-Ze Hong (Peter Hong) wrote:
> The Fintek F81532A/534A/535/536 is USB-to-2/4/8/12 serial ports device
> and the serial port is default disabled when plugin computer.
>
> The IC is contains devices as following:
> 1. HUB (all devices is connected with this hub)
> 2. GPIO/Control device. (enable serial port and control GPIOs)
> 3. serial port 1 to x (2/4/8/12)
>
> It's most same with F81232, the UART device is difference as follow:
> 1. TX/RX bulk size is 128/512bytes
> 2. RX bulk layout change:
> F81232: [LSR(1Byte)+DATA(1Byte)][LSR(1Byte)+DATA(1Byte)]...
> F81534A:[LEN][Data.....][LSR]
>
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
> +static void f81534a_process_read_urb(struct urb *urb)
> +{
> + struct usb_serial_port *port = urb->context;
> + unsigned char *data = urb->transfer_buffer;
> + char tty_flag;
> + unsigned int i;
> + u8 lsr;
> + u8 len;
> +
> + if (urb->actual_length < 3) {
> + dev_err(&port->dev, "short message received: %d\n",
> + urb->actual_length);
> + return;
> + }
> +
> + len = data[0];
> + if (len != urb->actual_length) {
> + dev_err(&port->dev, "unexpected length: %d %d\n", len,
> + urb->actual_length);
> + return;
I rephrased this as
dev_err(&port->dev, "malformed message received: %d (%d)\n",
urb->actual_length, len);
before applying.
Johan
next prev parent reply other threads:[~2020-02-25 11:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 5:47 [PATCH V3 0/6] Add Fintek F81534A series usb-to-serial driver Ji-Ze Hong (Peter Hong)
2020-01-30 5:47 ` [PATCH V3 1/6] USB: serial: f81232: Extract LSR handler Ji-Ze Hong (Peter Hong)
2020-01-30 5:47 ` [PATCH V3 2/6] USB: serial: f81232: Add tx_empty function Ji-Ze Hong (Peter Hong)
2020-01-30 5:47 ` [PATCH V3 3/6] USB: serial: f81232: Use devm_kzalloc Ji-Ze Hong (Peter Hong)
2020-01-30 5:47 ` [PATCH V3 4/6] USB: serial: f81232: Add F81534A support Ji-Ze Hong (Peter Hong)
2020-02-25 11:13 ` Johan Hovold [this message]
2020-01-30 5:47 ` [PATCH V3 5/6] USB: serial: f81232: Set F81534A serial port with RS232 mode Ji-Ze Hong (Peter Hong)
2020-01-30 5:47 ` [PATCH V3 6/6] USB: serial: f81232: Add generator for F81534A Ji-Ze Hong (Peter Hong)
2020-02-25 11:23 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225111332.GS32540@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=hpeter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).