From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: <linux-usb@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
"Lee, Chiasheng" <chiasheng.lee@intel.com>,
Mathieu Malaterre <malat@debian.org>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Eugeniu Rosca <erosca@de.adit-jv.com>,
Hardik Gajjar <hgajjar@de.adit-jv.com>, <scan-admin@coverity.com>
Subject: [PATCH] usb: hub: Fix unhandled return value of usb_autopm_get_interface()
Date: Tue, 25 Feb 2020 14:08:46 +0100 [thread overview]
Message-ID: <20200225130846.20236-1-erosca@de.adit-jv.com> (raw)
Address below Coverity complaint (Feb 25, 2020, 8:06 AM CET):
*** CID 1458999: Error handling issues (CHECKED_RETURN)
/drivers/usb/core/hub.c: 1869 in hub_probe()
1863
1864 if (id->driver_info & HUB_QUIRK_CHECK_PORT_AUTOSUSPEND)
1865 hub->quirk_check_port_auto_suspend = 1;
1866
1867 if (id->driver_info & HUB_QUIRK_DISABLE_AUTOSUSPEND) {
1868 hub->quirk_disable_autosuspend = 1;
>>> CID 1458999: Error handling issues (CHECKED_RETURN)
>>> Calling "usb_autopm_get_interface" without checking return value (as is done elsewhere 97 out of 111 times).
1869 usb_autopm_get_interface(intf);
1870 }
1871
1872 if (hub_configure(hub, &desc->endpoint[0].desc) >= 0)
1873 return 0;
1874
Fixes: 1208f9e1d758c9 ("USB: hub: Fix the broken detection of USB3 device in SMSC hub")
Cc: Hardik Gajjar <hgajjar@de.adit-jv.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reported-by: scan-admin@coverity.com
Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
---
drivers/usb/core/hub.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 1d212f82c69b..ff04ca28970d 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -1865,8 +1865,12 @@ static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id)
hub->quirk_check_port_auto_suspend = 1;
if (id->driver_info & HUB_QUIRK_DISABLE_AUTOSUSPEND) {
- hub->quirk_disable_autosuspend = 1;
- usb_autopm_get_interface(intf);
+ int r = usb_autopm_get_interface(intf);
+
+ if (!r)
+ hub->quirk_disable_autosuspend = 1;
+ else
+ dev_dbg(&intf->dev, "disable autosuspend err=%d\n", r);
}
if (hub_configure(hub, &desc->endpoint[0].desc) >= 0)
--
2.25.0
next reply other threads:[~2020-02-25 13:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 13:08 Eugeniu Rosca [this message]
2020-02-25 15:32 ` [PATCH] usb: hub: Fix unhandled return value of usb_autopm_get_interface() Alan Stern
2020-02-25 19:12 ` Eugeniu Rosca
2020-02-25 19:39 ` Alan Stern
2020-02-25 20:22 ` Eugeniu Rosca
2020-02-25 20:54 ` Alan Stern
2020-02-26 18:10 ` Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225130846.20236-1-erosca@de.adit-jv.com \
--to=erosca@de.adit-jv.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=chiasheng.lee@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hgajjar@de.adit-jv.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=malat@debian.org \
--cc=scan-admin@coverity.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).