From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Donghoon Yu <hoony.yu@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Shinbeom Choi <sbeom.choi@samsung.com>,
Hyunki Koo <kkoos00@naver.com>, Kukjin Kim <kgene@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Jiri Slaby <jslaby@suse.com>,
HYUN-KI KOO <hyunki00.koo@samsung.com>
Subject: Re: [PATCH 1/2] tty: serial: samsung_tty: build it for any platform
Date: Tue, 25 Feb 2020 21:41:51 +0100 [thread overview]
Message-ID: <20200225204151.GA13254@kroah.com> (raw)
In-Reply-To: <CAMuHMdXzPPNqQom82frY1B6LMre+VD9fPAf98BZ3eo2DhgwoYg@mail.gmail.com>
On Tue, Feb 25, 2020 at 09:52:38AM +0100, Geert Uytterhoeven wrote:
> On Thu, Feb 20, 2020 at 1:13 PM Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
> > On 2/20/20 11:26 AM, Greg Kroah-Hartman wrote:
> > > There is no need to tie this driver to only a specific SoC, or compile
> > > test, so remove that dependancy from the Kconfig rules.
> >
> > samsung_tty driver is hardware specific driver so why should we
> > build it for any platform?
Why not?
Seriously, this "only this one specific SoC is allowed to build this
driver" is crazy. It prevents anyone from building a generic kernel
with drivers as a module which are loaded as needed.
That needs to be fixed, and removing this unneeded dependancy on this
driver allows it to be build for any system and then only loaded when
needed.
> > This change seems to defeat the whole purpose behind COMPILE_TEST
> > config option (which allows us to build hardware-specific drivers
> > without needlessly presenting the user with tons of non-relevant
> > config options).
> >
> > Please explain this change some more, are you planing to remove
> > COMPILE_TEST config option?
I want to get rid of this:
> > > - depends on PLAT_SAMSUNG || ARCH_EXYNOS || COMPILE_TEST
We should not need PLAT_SAMSUNG or ARCH_EXYNOS at all, we should be able
to build an arm64 kernel for all platforms.
thanks,
greg k-h
next prev parent reply other threads:[~2020-02-25 20:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 10:26 [PATCH 1/2] tty: serial: samsung_tty: build it for any platform Greg Kroah-Hartman
2020-02-20 10:26 ` [PATCH 2/2] tty: serial: samsung_tty: remove SERIAL_SAMSUNG_DEBUG Greg Kroah-Hartman
2020-02-20 10:55 ` Krzysztof Kozlowski
2020-02-20 11:09 ` Greg Kroah-Hartman
2020-02-20 10:54 ` [PATCH 1/2] tty: serial: samsung_tty: build it for any platform Krzysztof Kozlowski
[not found] ` <CGME20200220121333eucas1p26befa95831b44a793822b4f07b37d2cc@eucas1p2.samsung.com>
2020-02-20 12:13 ` Bartlomiej Zolnierkiewicz
2020-02-25 8:52 ` Geert Uytterhoeven
2020-02-25 20:41 ` Greg Kroah-Hartman [this message]
2020-02-25 21:22 ` Geert Uytterhoeven
2020-02-26 10:11 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225204151.GA13254@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=geert@linux-m68k.org \
--cc=hoony.yu@samsung.com \
--cc=hyunki00.koo@samsung.com \
--cc=jslaby@suse.com \
--cc=kgene@kernel.org \
--cc=kkoos00@naver.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sbeom.choi@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).