From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 318B0C4BA0A for ; Wed, 26 Feb 2020 08:05:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0343421D7E for ; Wed, 26 Feb 2020 08:05:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582704305; bh=6mpYp3VSLsGhePsNl9NhezAX3lGlQZe76/ALlOLckQA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SKWB5chtjURcaPoqS3Jjv1kMdCkbxyoeS2Op1OZLIdrGTl34OihAebl6XMu+hHWAW aFNjmpEd7pyluDGNC6B93J6vZiGgIjutbyEnDRLjNValEyQJROnLlaocIXD2u8PFom kHKFq29/hdEHFvwci4/SVXgy3UJ9hMFMeToEqWbs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727459AbgBZIFD (ORCPT ); Wed, 26 Feb 2020 03:05:03 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:37603 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727223AbgBZIFD (ORCPT ); Wed, 26 Feb 2020 03:05:03 -0500 Received: by mail-lj1-f193.google.com with SMTP id q23so1968767ljm.4; Wed, 26 Feb 2020 00:05:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=yKvVSicnRjGL1KBR6OA7vuLTKFiFx2PtDbuSAdj12/E=; b=ccAHqfwxytj3lNoBs6NBqWkrY7cQJN4MpDoDgQ1nI+sUi/ZJyGw1h1fGMsVgK3TTLr P+u6sPsrecETJFW4hbw3lzJk1FBYjpeqi+Wrz7q9uf01kCPQygsZpIpVwC3jIRntLypv d8UaCT4iBsgBxAgt7v6Ko7KPRzYjTuuNa1UbFMaYDZwUGbqxDWUbaLkUHpQP+zPRrVVq NHdTRv9slJ/O1IDK+tOv17WkX4v9M0MemQBplpuFXQYeqig/JtcbqRiAUhR+/tACERDq oYWiOoCsFO9jf5KCMIE/pYslEW7Fn0xa9hByVziyV9YsM6mot7gf41CmF7S5eWVl7smf WA/w== X-Gm-Message-State: APjAAAVn4OrSLWGQ9N0MEBnL5CEgbo68v2X2XGrDyRdI6HY4Cf3nEozq oowwbUFhutfSu5c0dDsV7Vf9Nv3x X-Google-Smtp-Source: APXvYqxtBp00ozcwsH0h6RkFNguOuXbrCq3p9SMa4uqnZ0wQB9w9DHyXdONrvcFY0NUSwaXfHsFfqw== X-Received: by 2002:a2e:8145:: with SMTP id t5mr2166288ljg.144.1582704300911; Wed, 26 Feb 2020 00:05:00 -0800 (PST) Received: from xi.terra (c-12aae455.07-184-6d6c6d4.bbcust.telenor.se. [85.228.170.18]) by smtp.gmail.com with ESMTPSA id a3sm570720lfo.70.2020.02.26.00.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2020 00:05:00 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.92.3) (envelope-from ) id 1j6rgh-0001U3-EC; Wed, 26 Feb 2020 09:04:59 +0100 Date: Wed, 26 Feb 2020 09:04:59 +0100 From: Johan Hovold To: Tiezhu Yang Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Xuefeng Li Subject: Re: [PATCH 1/2] USB: core: Fix build warning in usb_get_configuration() Message-ID: <20200226080459.GU32540@localhost> References: <1582697723-7274-1-git-send-email-yangtiezhu@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1582697723-7274-1-git-send-email-yangtiezhu@loongson.cn> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 26, 2020 at 02:15:22PM +0800, Tiezhu Yang wrote: > There is no functional issue, just fix the following build warning: > > CC drivers/usb/core/config.o > drivers/usb/core/config.c: In function ‘usb_get_configuration’: > drivers/usb/core/config.c:868:6: warning: ‘result’ may be used uninitialized in this function [-Wmaybe-uninitialized] > int result; > ^ What compiler are you using? The warning is clearly bogus and it hasn't been seen with any recent gcc at least. > Signed-off-by: Tiezhu Yang > --- > drivers/usb/core/config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c > index b7918f6..bb63ee0 100644 > --- a/drivers/usb/core/config.c > +++ b/drivers/usb/core/config.c > @@ -865,7 +865,7 @@ int usb_get_configuration(struct usb_device *dev) > unsigned int cfgno, length; > unsigned char *bigbuffer; > struct usb_config_descriptor *desc; > - int result; > + int result = 0; > > if (ncfg > USB_MAXCONFIG) { > dev_warn(ddev, "too many configurations: %d, " Johan